From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Bossart, Nathan <bossartn@amazon.com>
Cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Julien Rouhaud <rjuju123@gmail.com>
Cc: shiy.fnst@fujitsu.com <shiy.fnst@fujitsu.com>
Cc: pgsql-hackers@lists.postgresql.org <pgsql-hackers@lists.postgresql.org>
Subject: Re: psql - add SHOW_ALL_RESULTS option
Date: Thu, 15 Apr 2021 13:51:20 +0200 (CEST)
Message-ID: <alpine.DEB.2.22.394.2104151336060.191178@pseudo> (raw)
In-Reply-To: <3738387.1618451507@sss.pgh.pa.us>
References: <69C0B369-570C-4524-8EE4-BCCACECB6BEE@amazon.com>
<20210412193301.GA11204@alvherre.pgsql>
<YHeVHH0wVcRwdogL@paquier.xyz>
<3738387.1618451507@sss.pgh.pa.us>
Hello Tom,
>> That's a lot IMO, so my vote would be to discard this feature for now
>> and revisit it properly in the 15 dev cycle, so as resources are
>> redirected into more urgent issues (13 open items as of the moment of
>> writing this email).
>
> I don't wish to tell people which open issues they ought to work on
> ... but this patch seems like it could be quite a large can of worms,
> and I'm not detecting very much urgency about getting it fixed.
> If it's not to be reverted then some significant effort needs to be
> put into it soon.
My overly naive trust in non regression test to catch any issues has been
largely proven wrong. Three key features do not have a single tests. Sigh.
I'll have some time to look at it over next week-end, but not before.
--
Fabien.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: coelho@cri.ensmp.fr, tgl@sss.pgh.pa.us, michael@paquier.xyz, alvherre@alvh.no-ip.org, bossartn@amazon.com, peter.eisentraut@enterprisedb.com, rjuju123@gmail.com, shiy.fnst@fujitsu.com, pgsql-hackers@lists.postgresql.org
Subject: Re: psql - add SHOW_ALL_RESULTS option
In-Reply-To: <alpine.DEB.2.22.394.2104151336060.191178@pseudo>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox