From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Gregory Smith <gregsmithpgsql@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: david.christensen@crunchydata.com
Subject: Re: pgbench logging broken by time logic changes
Date: Thu, 17 Jun 2021 22:53:26 +0200 (CEST)
Message-ID: <alpine.DEB.2.22.394.2106172244580.2941201@pseudo> (raw)
In-Reply-To: <CA+hUKGKJu21ieM+w73mvMGmnaHBhYtUihLHdnCCYPQU51wnwuw@mail.gmail.com>
References: <CAHLJuCW_8Vpcr0=t6O_gozrg3wXXWXZXDioYJd3NhvKriqgpfQ@mail.gmail.com>
<CA+hUKG+jhatozihmqy4=Ufd0OHwZadEd_vg-_+26hE3f4C3TgQ@mail.gmail.com>
<alpine.DEB.2.22.394.2106170917240.2693553@pseudo>
<CA+hUKGKJu21ieM+w73mvMGmnaHBhYtUihLHdnCCYPQU51wnwuw@mail.gmail.com>
Hello Thomas,
> I prepared a draft revert patch for discussion, just in case it comes
> in handy. This reverts "pgbench: Improve time logic.", but "pgbench:
> Synchronize client threads." remains (slightly rearranged).
I had a quick look.
I had forgotten that this patch also fixed the long-running brain-damaged
tps computation that has been bothering me for years, so that one sane
performance figure is now reported instead of two not-clear-to-interpret
take-your-pick figures.
It would be a real loss if this user-facing fix is removed in the
process:-(
--
Fabien.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: coelho@cri.ensmp.fr, thomas.munro@gmail.com, gregsmithpgsql@gmail.com, david.christensen@crunchydata.com
Subject: Re: pgbench logging broken by time logic changes
In-Reply-To: <alpine.DEB.2.22.394.2106172244580.2941201@pseudo>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox