From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Cc: Thomas Munro <thomas.munro@gmail.com>
Subject: Re: Version reporting in pgbench
Date: Fri, 18 Jun 2021 20:27:16 +0200 (CEST)
Message-ID: <alpine.DEB.2.22.394.2106182021570.3211875@pseudo> (raw)
In-Reply-To: <1226654.1624036821@sss.pgh.pa.us>
References: <1226654.1624036821@sss.pgh.pa.us>
Hello Tom,
> One point here is that printing the server version requires
> access to a connection, which printResults() hasn't got
> because we already closed all the connections by that point.
> I solved that by printing the banner during the initial
> connection that gets the scale factor, does vacuuming, etc.
Ok.
> If you're dead set on not printing the version till the end,
> that could be made to happen; but it's not clear to me that
> this way is any worse, and it's certainly easier.
pgbench (14beta1 dev 2021-06-12 08:10:44, server 13.3 (Ubuntu 13.3-1.pgdg20.04+1))
Why not move the printVersion call right after the connection is created,
at line 6374?
Otherwise it works for me.
--
Fabien.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: coelho@cri.ensmp.fr, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org, thomas.munro@gmail.com
Subject: Re: Version reporting in pgbench
In-Reply-To: <alpine.DEB.2.22.394.2106182021570.3211875@pseudo>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox