From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Cc: Thomas Munro <thomas.munro@gmail.com>
Subject: Re: Version reporting in pgbench
Date: Fri, 18 Jun 2021 23:37:44 +0200 (CEST)
Message-ID: <alpine.DEB.2.22.394.2106182336550.3211875@pseudo> (raw)
In-Reply-To: <1320810.1624051719@sss.pgh.pa.us>
References: <1226654.1624036821@sss.pgh.pa.us>
<alpine.DEB.2.22.394.2106182021570.3211875@pseudo>
<1234107.1624041603@sss.pgh.pa.us>
<alpine.DEB.2.22.394.2106182300170.3211875@pseudo>
<1320810.1624051719@sss.pgh.pa.us>
>> Note that if no connections are available, then you do not get the
>> version, which may be a little bit strange. Attached v3 prints out the
>> local version in that case. Not sure whether it is worth the effort.
>
> I'm inclined to think that the purpose of that output is mostly
> to report the server version, so not printing it if we fail to
> connect isn't very surprising. Certainly that's how psql has
> acted for decades.
I'm fine with having a uniform behavior over pg commands.
Thanks for the improvement!
--
Fabien.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: coelho@cri.ensmp.fr, tgl@sss.pgh.pa.us, pgsql-hackers@lists.postgresql.org, thomas.munro@gmail.com
Subject: Re: Version reporting in pgbench
In-Reply-To: <alpine.DEB.2.22.394.2106182336550.3211875@pseudo>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox