From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Michael Paquier <michael@paquier.xyz>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Some code cleanup for pgbench and pg_verifybackup
Date: Wed, 28 Jul 2021 08:49:12 +0200 (CEST)
Message-ID: <alpine.DEB.2.22.394.2107280844590.1963471@pseudo> (raw)
In-Reply-To: <YQDMdB+B68yePFeT@paquier.xyz>
References: <alpine.DEB.2.22.394.2107260946550.297424@pseudo>
<202107261935.tad2ojwemn3v@alvherre.pgsql>
<YP9LEHjcSng0Yk0R@paquier.xyz>
<YQDMdB+B68yePFeT@paquier.xyz>
> [...] Thoughts?
For pgbench it is definitely ok to add the exit. For others the added
exits look reasonable, but I do not know them intimately enough to be sure
that it is the right thing to do in all cases.
> All that does not seem to enter into the category of things worth
> back-patching, except for pg_verifybackup.
Yes.
--
Fabien.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: coelho@cri.ensmp.fr, michael@paquier.xyz, alvherre@alvh.no-ip.org, pgsql-hackers@lists.postgresql.org
Subject: Re: Some code cleanup for pgbench and pg_verifybackup
In-Reply-To: <alpine.DEB.2.22.394.2107280844590.1963471@pseudo>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox