pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: pgsql-hackers@lists.postgresql.org <pgsql-hackers@lists.postgresql.org>
Subject: Re: psql - add SHOW_ALL_RESULTS option
Date: Sun, 23 Jan 2022 18:17:37 +0100 (CET)
Message-ID: <alpine.DEB.2.22.394.2201231810310.1496591@pseudo> (raw)
In-Reply-To: <47bcee2e-3e4c-a0ea-daee-9b3e2d65df05@enterprisedb.com>
References: <18c78a01-4a34-9dd4-f78b-6860f1420c8e@enterprisedb.com>
	<alpine.DEB.2.22.394.2107221655020.25741@pseudo>
	<6954328d-96f2-77f7-735f-7ce493a40949@enterprisedb.com>
	<alpine.DEB.2.22.394.2109251058000.3216312@pseudo>
	<alpine.DEB.2.22.394.2110021622530.2817726@pseudo>
	<2570e2ae-fa0f-aac9-f72f-bb59a9983a20@enterprisedb.com>
	<alpine.DEB.2.22.394.2112230703530.2668598@pseudo>
	<46259d13-5f90-1475-3c85-d7a597a2b862@enterprisedb.com>
	<alpine.DEB.2.22.394.2201040851220.3857182@pseudo>
	<alpine.DEB.2.22.394.2201081931170.731324@pseudo>
	<20220113054433.wdjhidtm7gvyhfts@alap3.anarazel.de>
	<alpine.DEB.2.22.394.2201150938470.3378943@pseudo>
	<47bcee2e-3e4c-a0ea-daee-9b3e2d65df05@enterprisedb.com>


Hallo Peter,

>> Attached v14 moves the status extraction before the possible clear. I've 
>> added a couple of results = NULL after such calls in the code.
>
> In the psql.sql test file, the test I previously added concluded with \set 
> ECHO none, which was a mistake that I have now fixed.  As a result, the tests 
> that you added after that point didn't show their input lines, which was 
> weird and not intentional.  So the tests will now show a different output.

Ok.

> I notice that this patch has recently gained a new libpq function.  I gather 
> that this is to work around the misbehaviors in libpq that we have discussed.

Indeed.

> But I think if we are adding a libpq API function to work around a 
> misbehavior in libpq, we might as well fix the misbehavior in libpq to 
> begin with. Adding a new public libpq function is a significant step, 
> needs documentation, etc.

I'm not so sure.

The choice is (1) change the behavior of an existing function or (2) add a 
new function. Whatever the existing function does, the usual anwer to API 
changes is "someone is going to complain because it breaks their code", so 
"Returned with feedback", hence I did not even try. The advantage of (2) 
is that it does not harm anyone to have a new function that they just do 
not need to use.

> It would be better to do without.  Also, it makes one wonder how others 
> are supposed to use this multiple-results API properly, if even psql 
> can't do it without extending libpq. Needs more thought.

Fine with me! Obviously I'm okay if libpq is repaired instead of writing 
strange code on the client to deal with strange behavior.

-- 
Fabien.





view thread (127+ messages)  latest in thread

Message-ID: <alpine.DEB.2.22.394.2201231810310.1496591@pseudo>
Permalink:  ../alpine.DEB.2.22.394.2201231810310.1496591@pseudo/
Also on:    postgresql.org/message-id/alpine.DEB.2.22.394.2201231810310.1496591@pseudo

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: coelho@cri.ensmp.fr, peter.eisentraut@enterprisedb.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: psql - add SHOW_ALL_RESULTS option
  In-Reply-To: <alpine.DEB.2.22.394.2201231810310.1496591@pseudo>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox