From: Fabien COELHO <coelho@cri.ensmp.fr>
To: Tatsuo Ishii <ishii@sraoss.co.jp>
Cc: tgl@sss.pgh.pa.us
Cc: alvherre@alvh.no-ip.org
Cc: nagata@sraoss.co.jp
Cc: thomas.munro@gmail.com
Cc: m.polyakova@postgrespro.ru
Cc: pgsql-hackers@postgresql.org
Cc: teodor@sigaev.ru
Subject: Re: [HACKERS] WIP aPatch: Pgbench Serialization and deadlock errors
Date: Sun, 3 Apr 2022 10:20:05 +0200 (CEST)
Message-ID: <alpine.DEB.2.22.394.2204030956500.2117840@pseudo> (raw)
In-Reply-To: <20220403.152819.1855287099476193181.t-ishii@sranhm.sra.co.jp>
References: <202203280757.3tu4ovs3petm@alvherre.pgsql>
<701162.1648474392@sss.pgh.pa.us>
<20220401.095700.2266633058878785752.t-ishii@sranhm.sra.co.jp>
<20220403.152819.1855287099476193181.t-ishii@sranhm.sra.co.jp>
>> Or those three columns always, sum_lag sum_lag_2, min_lag max_lag,
>> skipped, retried retries?
>
> What about this? (a log line is not actually folded)
> interval_start num_transactions sum_latency sum_latency_2 min_latency max_latency
> failures serialization_failures deadlock_failures retried retries [ sum_lag sum_lag_2 min_lag max_lag [ skipped ] ]
My 0.02€:
I agree that it would be better to have a more deterministic
aggregated log format.
ISTM that it should skip failures and lags if no fancy options has been
selected, i.e.:
[ fails ... retries [ sum_lag ... [ skipped ] ] ?
Alterlatively, as the failure stuff is added to the format, maybe it could
be at the end:
[ sum_lag ... [ skipped [ fails ... retries ] ] ] ?
> failures:
> always 0 (if --max-tries is 1, the default)
> sum of serialization_failures and deadlock_failures (if --max-tries is not 1)
>
> serialization_failures and deadlock_failures:
> always 0 (if --max-tries is 1, the default)
> 0 or more (if --max-tries is not 1)
>
> retried and retries:
> always 0 (if --max-tries is 1, the default)
> 0 or more (if --max-tries is not 1)
>
> Best reagards,
> --
> Tatsuo Ishii
> SRA OSS, Inc. Japan
> English: http://www.sraoss.co.jp/index_en.php
> Japanese:http://www.sraoss.co.jp
>
--
Fabien.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: coelho@cri.ensmp.fr, ishii@sraoss.co.jp, tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, nagata@sraoss.co.jp, thomas.munro@gmail.com, m.polyakova@postgrespro.ru, teodor@sigaev.ru
Subject: Re: [HACKERS] WIP aPatch: Pgbench Serialization and deadlock errors
In-Reply-To: <alpine.DEB.2.22.394.2204030956500.2117840@pseudo>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox