agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: Nathan Bossart <nathandbossart@gmail.com>
To: Antonin Houska <ah@cybertec.at>
Cc: Fujii Masao <masao.fujii@gmail.com>
Cc: pgsql-hackers@postgresql.org
Cc: alvherre@kurilemu.de
Subject: Re: REPACK (ANALYZE) within transaction block segfaults
Date: Fri, 28 Aug 2026 14:52:09 -0500
Message-ID: <apHm6bHknXuEyElx@nathan> (raw)
In-Reply-To: <49398.1787944525@localhost>
References: <apBCEl4hBHlq0axm@nathan>
<CAHGQGwEqN80ka_PY__DiPCu+S=h_7KgujnMEU38OU9C1zsGQpA@mail.gmail.com>
<apCSd2NvvEJfBmVu@nathan>
<49398.1787944525@localhost>
On Fri, Aug 28, 2026 at 09:15:25PM +0200, Antonin Houska wrote:
> I think there are just two different concepts (for historical reasons?):
> vacuum_rel() expects no active transaction on entry, while cluster_rel()
> handles transaction boundaries on its own.
>
> Since REPACK (ANALYZE) is effectively VACUUM (FULL, ANALYZE), I'd prefer the
> same behavior, i.e. prohibiting execution both in a transaction block and in a
> function:
This is probably the way to go for v19. As you note, the analogous VACUUM
command has long ERROR'd, and we could always look into removing this
restriction in the future. I'd rather do it that way than ship an
incorrect fix in v19 that will be tougher to back out.
--
nathan
view thread (25+ messages) latest in thread
Message-ID: <apHm6bHknXuEyElx@nathan>
Permalink: ../apHm6bHknXuEyElx@nathan/
Also on: postgresql.org/message-id/apHm6bHknXuEyElx@nathan
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: nathandbossart@gmail.com, ah@cybertec.at, masao.fujii@gmail.com, alvherre@kurilemu.de
Subject: Re: REPACK (ANALYZE) within transaction block segfaults
In-Reply-To: <apHm6bHknXuEyElx@nathan>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox