From: Álvaro Herrera <alvherre@kurilemu.de>
To: Sami Imseih <samimseih.pg@gmail.com>
Cc: Xuneng Zhou <xunengzhou@gmail.com>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Reject WAIT FOR earlier in transaction-snapshot mode
Date: Wed, 9 Sep 2026 17:24:51 +0200
Message-ID: <aqFqbW8Q82DcA3DQ@alvherre.pgsql> (raw)
In-Reply-To: <CAN12+YL=5a24oTYSj_Qs0Y80spS0MDwX5egcriXBqdHgpGiX4Q@mail.gmail.com>
Hi,
Not critically important but note that the PopActiveSnapshot and
InvalidateCatalogSnapshot call and the comment about "giving up if there
is still an active or registered snapshot" have a close relationship; I
think it would make sense to keep them together. I would add your new
test-and-ereport just before the PopActiveSnapshot() call, to avoid
breaking that.
Cheers
--
Álvaro Herrera 48°01'N 7°57'E — https://www.EnterpriseDB.com/
"Siempre hay que alimentar a los dioses, aunque la tierra esté seca" (Orual)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: alvherre@kurilemu.de, samimseih.pg@gmail.com, xunengzhou@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Reject WAIT FOR earlier in transaction-snapshot mode
In-Reply-To: <aqFqbW8Q82DcA3DQ@alvherre.pgsql>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox