agora inbox for pgsql-hackers@postgresql.org  

help / color / mirror / Atom feed

From: Álvaro Herrera <alvherre@kurilemu.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Narek Galstyan <narek.galstyan@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org, "narekg@berkeley.edu" <narekg@berkeley.edu>
Cc: ngalstyan4@gmail.com
Subject: Re: Coverage with make coverage-html is broken on latest Debian using lcov v2
Date: Sat, 3 Oct 2026 23:23:16 +0200
Message-ID: <asFSm3xLI9bkHJey@alvherre.pgsql> (raw)
In-Reply-To: <242900.1791053460@sss.pgh.pa.us>

On 2026-Oct-03, Tom Lane wrote:

> Testing this locally, it initially didn't seem to be doing anything.
> But that turns out to be because Red Hat has stuck with lcov 2.0-1,
> which does not produce the "duplicate file" error.  What it does do
> is blindly read every foo.gcda file twice, resulting in counts twice
> what they should be :-(.  Now I wonder whether pre-2.0 lcov did the
> same ... but I don't have an old executable laying about to test with.
> 
> I gather that coverage.postgresql.org is running a VPATH build,
> because it shows some odd coverage counts as well as even ones.
> That's impossible in an in-tree build with this bug, if I've
> diagnosed it correctly.

Hmm, no, it's running an in-tree build,

./configure --cache-file=/home/coverage/pgsrc/configure.cache --enable-depend --enable-coverage --enable-tap-tests --enable-nls --with-python --with-perl --with-tcl --with-openssl --with-libxml --with-ldap --with-pam --with-llvm --with-lz4 --enable-injection-points CFLAGS=-O0 'CPPFLAGS=-DCOPY_PARSE_PLAN_TREES -DWRITE_READ_PARSE_PLAN_TREES -DRAW_EXPRESSION_COVERAGE_TEST' LLVM_CONFIG=/usr/bin/llvm-config-19 CLANG=clang-19 >> $LOG 2>&1

So, I was going to say that Debian packages the same version:

coverage@galvin:~$ lcov --version
lcov: LCOV version 2.0-1

but I found out that the packaging files have a patch file that modifies
the version string, so the code that's actually running is 2.3, not 2.0.

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1142382

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"La espina, desde que nace, ya pincha" (Proverbio africano)

view thread (10+ messages)  latest in thread

Message-ID: <asFSm3xLI9bkHJey@alvherre.pgsql>
Permalink:  ../asFSm3xLI9bkHJey@alvherre.pgsql/
Also on:    postgresql.org/message-id/asFSm3xLI9bkHJey@alvherre.pgsql

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: alvherre@kurilemu.de, tgl@sss.pgh.pa.us, narek.galstyan@enterprisedb.com, narekg@berkeley.edu, ngalstyan4@gmail.com
  Subject: Re: Coverage with make coverage-html is broken on latest Debian using lcov v2
  In-Reply-To: <asFSm3xLI9bkHJey@alvherre.pgsql>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox