pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Bertrand Drouvot <bertranddrouvot.pg@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Zhijie Hou <houzhijie22@gmail.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: Chao Li <li.evan.chao@gmail.com>
Cc: Fujii Masao <masao.fujii@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Add a hook for handling logical decoding messages on subscribers.
Date: Thu, 12 Nov 2026 10:06:02 +0000
Message-ID: <avWPil2vQXgXQBn+@bdtpg> (raw)
In-Reply-To: <CAA4eK1K3ypFDLk1R1DEx7YqCRbjNLTtJPP5+FfcX0F63rQ+Ekg@mail.gmail.com>
References: <CALj2ACVj+khUL=8Y3ukqJ6uF8cr0kmY6Q++fxJKYZ4P4bww=AA@mail.gmail.com>
	<CAD21AoAP9iYrJh4HkPYBfiQAncyw-ch7uiyXyeQ=yyyxU-V8xQ@mail.gmail.com>
	<CALj2ACVuHCZJ2vdrbB22LG77gCjwsw2DYcqNEy8GuHuKe_1Agg@mail.gmail.com>
	<CAD21AoD5rwBPQv-_dGZEdsgzL7H1KywpsAd5HD3-DWKGQ5oTeQ@mail.gmail.com>
	<b9b5bd27-6416-48b4-8f73-c5a60e2c97e2@gmail.com>
	<CAA4eK1J1Jdz6DunCPWJ2KCpGbSERxgv+xydXkTa+19GgG5dPOA@mail.gmail.com>
	<CAD21AoAhdXE1+i_bfGx3H=MheEizysk8uRirkZ3Y-v=AJzVvYw@mail.gmail.com>
	<CAD21AoC-pOvm54YzNiihFS90kSDRWr=qG6BE-9HW-YW=tqRubw@mail.gmail.com>
	<CAD21AoAWtvvHi1F2kSU2wOvNxfSDzQWNXYW4yL4B4Ttoq-Ek7A@mail.gmail.com>
	<CAA4eK1K3ypFDLk1R1DEx7YqCRbjNLTtJPP5+FfcX0F63rQ+Ekg@mail.gmail.com>

Hi,

Sorry for joining this discussion so late.

On Thu, Nov 12, 2026 at 03:02:44PM +0530, Amit Kapila wrote:
> On Thu, Nov 12, 2026 at 4:10 AM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> >
> > On Mon, Nov 9, 2026 at 5:21 PM Masahiko Sawada <sawada.mshk@gmail.com> wrote:
> > >
> > > I've attached the new patches. I just updated the commit message for
> > > the 0001 patch, and added some fixes and regression tests for the 0002
> > > patch. Please review them.
> >
> > I think the 0001 patch can be pushed independently. So I'm going to
> > push it to master, barring objections.
> >
> 
> Few comments on 0001:
> * As we are planning this as a master-only change, will it be better
> if we just pass subxid as a separate parameter to keep the interface
> consistent with other similar interfaces and avoid the need for
> plugins to retrieve toptxn separately.

+1. That would also prevent the crash mentioned in the commit message, as txn
would remain the top level transaction.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com






view thread (43+ messages)  latest in thread

Message-ID: <avWPil2vQXgXQBn+@bdtpg>
Permalink:  ../avWPil2vQXgXQBn+@bdtpg/
Also on:    postgresql.org/message-id/avWPil2vQXgXQBn+@bdtpg

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: bertranddrouvot.pg@gmail.com, amit.kapila16@gmail.com, sawada.mshk@gmail.com, houzhijie22@gmail.com, bharath.rupireddyforpostgres@gmail.com, li.evan.chao@gmail.com, masao.fujii@gmail.com
  Subject: Re: Add a hook for handling logical decoding messages on subscribers.
  In-Reply-To: <avWPil2vQXgXQBn+@bdtpg>
  References: <CALj2ACVj+khUL=8Y3ukqJ6uF8cr0kmY6Q++fxJKYZ4P4bww=AA@mail.gmail.com> <CAD21AoAP9iYrJh4HkPYBfiQAncyw-ch7uiyXyeQ=yyyxU-V8xQ@mail.gmail.com> <CALj2ACVuHCZJ2vdrbB22LG77gCjwsw2DYcqNEy8GuHuKe_1Agg@mail.gmail.com> <CAD21AoD5rwBPQv-_dGZEdsgzL7H1KywpsAd5HD3-DWKGQ5oTeQ@mail.gmail.com> <b9b5bd27-6416-48b4-8f73-c5a60e2c97e2@gmail.com> <CAA4eK1J1Jdz6DunCPWJ2KCpGbSERxgv+xydXkTa+19GgG5dPOA@mail.gmail.com> <CAD21AoAhdXE1+i_bfGx3H=MheEizysk8uRirkZ3Y-v=AJzVvYw@mail.gmail.com> <CAD21AoC-pOvm54YzNiihFS90kSDRWr=qG6BE-9HW-YW=tqRubw@mail.gmail.com> <CAD21AoAWtvvHi1F2kSU2wOvNxfSDzQWNXYW4yL4B4Ttoq-Ek7A@mail.gmail.com> <CAA4eK1K3ypFDLk1R1DEx7YqCRbjNLTtJPP5+FfcX0F63rQ+Ekg@mail.gmail.com> <avWPil2vQXgXQBn+@bdtpg>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox