public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Fabien COELHO <[email protected]>
Cc: [email protected] <[email protected]>
Subject: Re: psql - add SHOW_ALL_RESULTS option
Date: Tue, 22 Mar 2022 16:01:17 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2203171859410.1198186@pseudo>
References: <[email protected]>
	<alpine.DEB.2.22.394.2107221655020.25741@pseudo>
	<[email protected]>
	<alpine.DEB.2.22.394.2109251058000.3216312@pseudo>
	<alpine.DEB.2.22.394.2110021622530.2817726@pseudo>
	<[email protected]>
	<alpine.DEB.2.22.394.2112230703530.2668598@pseudo>
	<[email protected]>
	<alpine.DEB.2.22.394.2201040851220.3857182@pseudo>
	<alpine.DEB.2.22.394.2201081931170.731324@pseudo>
	<[email protected]>
	<alpine.DEB.2.22.394.2201150938470.3378943@pseudo>
	<[email protected]>
	<alpine.DEB.2.22.394.2203041443080.538147@pseudo>
	<alpine.DEB.2.22.394.2203121726590.3679190@pseudo>
	<[email protected]>
	<alpine.DEB.2.22.394.2203171859410.1198186@pseudo>

On 17.03.22 19:04, Fabien COELHO wrote:
> Indeed! The missing part was put back in v17.

Some unrelated notes on this v17 patch:

-use Test::More;
+use Test::More tests => 41;

The test counts are not needed/wanted anymore.


+
+\set ECHO none
+

This seems inappropriate.


+--
+-- autocommit
+--

+--
+-- test ON_ERROR_ROLLBACK
+--

This test file already contains tests for autocommit and 
ON_ERROR_ROLLBACK.  If you want to change those, please add yours into 
the existing sections, not make new ones.  I'm not sure if your tests 
add any new coverage, or if it is just duplicate.

view thread (14+ messages)

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: psql - add SHOW_ALL_RESULTS option
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox