pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: warnings for invalid function casts
Date: Tue, 14 Jul 2020 20:58:28 +0200
Message-ID: <b49de4e4-458d-2be6-5905-feee41e74ee1@2ndquadrant.com> (raw)
In-Reply-To: <1527436.1594138095@sss.pgh.pa.us>
References: <1e97628e-6447-b4fd-e230-d109cec2d584@2ndquadrant.com>
	<474790.1593526505@sss.pgh.pa.us>
	<20200630192135.nwlza2u57dy3qej4@alap3.anarazel.de>
	<496552.1593545900@sss.pgh.pa.us>
	<c764383a-3f9e-f5ba-79d1-8824fe73340f@2ndquadrant.com>
	<931660.1593787200@sss.pgh.pa.us>
	<d04f3b48-8195-aa83-8862-b6d3747fed30@2ndquadrant.com>
	<1183184.1593872167@sss.pgh.pa.us>
	<2410175f-255d-ab5c-e95e-2dfc1bad3f97@2ndquadrant.com>
	<1527436.1594138095@sss.pgh.pa.us>

On 2020-07-07 18:08, Tom Lane wrote:
> Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
>> On 2020-07-04 16:16, Tom Lane wrote:
>>> I'm for a typedef.  There is *nothing* readable about "(void (*) (void))",
>>> and the fact that it's theoretically incorrect for the purpose doesn't
>>> exactly aid intelligibility either.  With a typedef, not only are
>>> the uses more readable but there's a place to put a comment explaining
>>> that this is notionally wrong but it's what gcc specifies to use
>>> to suppress thus-and-such warnings.
> 
>> Makes sense.  New patch here.
> 
> I don't have a compiler handy that emits these warnings, but this
> passes an eyeball check.

committed

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services





view thread (12+ messages)

Message-ID: <b49de4e4-458d-2be6-5905-feee41e74ee1@2ndquadrant.com>
Permalink:  ../b49de4e4-458d-2be6-5905-feee41e74ee1@2ndquadrant.com/
Also on:    postgresql.org/message-id/b49de4e4-458d-2be6-5905-feee41e74ee1@2ndquadrant.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@2ndquadrant.com, tgl@sss.pgh.pa.us, andres@anarazel.de
  Subject: Re: warnings for invalid function casts
  In-Reply-To: <b49de4e4-458d-2be6-5905-feee41e74ee1@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox