From: David Steele <david@pgmasters.net>
To: Stephen Frost <sfrost@snowman.net>
Cc: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Cc: Michael Paquier <michael.paquier@gmail.com>
Subject: Re: PATCH: Exclude unlogged tables from base backups
Date: Wed, 13 Dec 2017 10:44:38 -0500
Message-ID: <b947f3a1-cc9d-2aec-da43-ce19c06c22a2@pgmasters.net> (raw)
In-Reply-To: <20171213150456.GI4628@tamriel.snowman.net>
References: <04791bab-cb04-ba43-e9c0-664a4c1ffb2c@pgmasters.net>
<20171212225234.jqdwd4sp663l4znp@alap3.anarazel.de>
<5e428ad7-f37f-6479-aabf-2c8b9318fb79@pgmasters.net>
<20171212230740.evr7rvkzz5bztdg6@alap3.anarazel.de>
<20171213014804.GH4628@tamriel.snowman.net>
<d3f60151-03b3-9443-e07c-aaaf42e9dd55@pgmasters.net>
<20171213150456.GI4628@tamriel.snowman.net>
On 12/13/17 10:04 AM, Stephen Frost wrote:
>
> Just to be clear- the new base backup code doesn't actually *do* the
> non-init fork removal, it simply doesn't include the non-init fork in
> the backup when there is an init fork, right?
It does *not* do the unlogged non-init fork removal. The code I
refactored in reinit.c is about identifying the forks, not removing
them. That code is reused to determine what to exclude from the backup.
I added the regression tests to ensure that the behavior of reinit.c is
unchanged after the refactor.
> We certainly wouldn't want a basebackup actually running around removing
> the main fork for unlogged tables on a running and otherwise healthy
> system. ;)
That would not be good.
--
-David
david@pgmasters.net
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: david@pgmasters.net, sfrost@snowman.net, andres@anarazel.de, michael.paquier@gmail.com
Subject: Re: PATCH: Exclude unlogged tables from base backups
In-Reply-To: <b947f3a1-cc9d-2aec-da43-ce19c06c22a2@pgmasters.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox