From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: allow_system_table_mods and DROP RULE
Date: Fri, 20 Dec 2019 08:33:21 +0100
Message-ID: <b994b23d-ae32-8b77-ff2d-c56dfa13260e@2ndquadrant.com> (raw)
In-Reply-To: <CA+TgmoZHmkrs4KZKHDtKbSbjXnjVG_TgDGK3d0GmKPRqg-PwJQ@mail.gmail.com>
References: <ee9df1af-c0d8-7c82-5be7-39ce4e3b0a9d@2ndquadrant.com>
<CA+TgmoZHmkrs4KZKHDtKbSbjXnjVG_TgDGK3d0GmKPRqg-PwJQ@mail.gmail.com>
On 2019-12-18 16:53, Robert Haas wrote:
> On Wed, Dec 18, 2019 at 3:56 AM Peter Eisentraut
> <peter.eisentraut@2ndquadrant.com> wrote:
>> As a curious omission, DROP RULE does not check allow_system_table_mods.
>> Creating and renaming a rule does, and also creating, renaming, and
>> dropping a trigger does. The impact of this is probably nil in
>> practice, but for consistency we should probably add that. The patch is
>> pretty simple.
>
> +1. LGTM.
committed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, robertmhaas@gmail.com
Subject: Re: allow_system_table_mods and DROP RULE
In-Reply-To: <b994b23d-ae32-8b77-ff2d-c56dfa13260e@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox