public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Dave Cramer <[email protected]>
To: Tatsuo Ishii <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Cc: [email protected]
Subject: Re: Using defines for protocol characters
Date: Wed, 9 Aug 2023 17:19:20 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <CADK3HHJgZWCh8Kwvc41=B3nAXyP_iX0bFewe7+7q6qp1hXiW5g@mail.gmail.com>
References: <CADK3HHJBmf5YgbW4bnSA5kBawgrZxyxDa2xQJDFHoGdC6hhEgg@mail.gmail.com>
	<[email protected]>
	<20230807214714.GA1284531@nathanxps13>
	<[email protected]>
	<CADK3HHJgZWCh8Kwvc41=B3nAXyP_iX0bFewe7+7q6qp1hXiW5g@mail.gmail.com>

1. As was discussed, these definitions should go into 
src/include/libpq/pqcomm.h, not a new file.

2. I would prefer an underscore after PgMsg, like PqMsg_DescribeRequest, 
so it's easier to visually locate the start of the actual message name.

3. IMO, the names of the protocol messages in protocol.sgml are 
canonical.  Your patch appends "Request" and "Response" in cases where 
that is not part of the actual name.  Also, some messages are documented 
to go both ways, so this separation doesn't make sense strictly 
speaking.  Please use the names as in protocol.sgml without augmenting them.

view thread (18+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Using defines for protocol characters
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox