From: Quan Zongliang <quanzongliang@yeah.net>
To: Michael Paquier <michael@paquier.xyz>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: bugfix: when the blocksize is 32k, the function page_header of pageinspect returns negative numbers.
Date: Thu, 8 Jul 2021 18:02:03 +0800
Message-ID: <ba664e6a-1b83-e7a7-5f69-7dfd99a49e45@yeah.net> (raw)
In-Reply-To: <YOavSelqzR6bT1j+@paquier.xyz>
References: <8b8ec36e-61fe-14f9-005d-07bc85aa4eed@yeah.net>
<CALj2ACVvmn7RsV9BmXLKv9M-7WZtabyyALECsY_iKbz4Cj1VtA@mail.gmail.com>
<YOZ70IxyhdGzn6OE@paquier.xyz>
<20210708042806.GA22043@telsasoft.com>
<YOavSelqzR6bT1j+@paquier.xyz>
On 2021/7/8 3:54 下午, Michael Paquier wrote:
> On Wed, Jul 07, 2021 at 11:28:06PM -0500, Justin Pryzby wrote:
>> I think you can refer to this prior commit for guidance.
>>
>> commit f18aa1b203930ed28cfe42e82d3418ae6277576d
>> Author: Peter Eisentraut <peter@eisentraut.org>
>> Date: Tue Jan 19 10:28:05 2021 +0100
>>
>> pageinspect: Change block number arguments to bigint
>
> Yes, thanks. Peter's recent work is what I had in mind. I agree that
> we could improve the situation, and the change is not complicated once
> you know what needs to be done. It needs to be done as follows:
> - Create a new pageinspect--1.9--1.10.sql.
> - Provide a proper implementation for older extension version based on
> the output parameter types, with a lookup at the TupleDesc for the
> function to adapt.
> - Add tests to sql/oldextversions.sql to stress the old function based
> on smallint results.
> - Bump pageinspect.control.
>
> Quan, would you like to produce a patch? That's a good exercise to
> understand how the maintenance of extensions is done.
Ok. I'll do it.
> --
> Michael
>
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: quanzongliang@yeah.net, michael@paquier.xyz, pryzby@telsasoft.com, bharath.rupireddyforpostgres@gmail.com
Subject: Re: bugfix: when the blocksize is 32k, the function page_header of pageinspect returns negative numbers.
In-Reply-To: <ba664e6a-1b83-e7a7-5f69-7dfd99a49e45@yeah.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox