pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: David Steele <david@pgmasters.net>
To: Michael Paquier <michael@paquier.xyz>
Cc: Sergei Kornilov <sk@zsrv.org>
Cc: Andres Freund <andres@anarazel.de>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: Re: allow online change primary_conninfo
Date: Mon, 25 Mar 2019 12:32:21 +0400
Message-ID: <bb9961f5-3f75-41d0-a4cb-adf7741ea7dc@pgmasters.net> (raw)
In-Reply-To: <20190304031918.GH1999@paquier.xyz>
References: <4926831544698308@iva3-294f9af87d55.qloud-c.yandex.net>
	<20181214075542.GG2921@paquier.xyz>
	<20190131125837.6gtbdslj5atasuoz@alap3.anarazel.de>
	<6789441548940402@sas1-fb8a605c4548.qloud-c.yandex.net>
	<20190203105241.4hbq4cyl4hkrgnzq@alap3.anarazel.de>
	<17843631549197218@iva5-d3020dc3459d.qloud-c.yandex.net>
	<20190216035316.6q23okurzacergea@alap3.anarazel.de>
	<7431841550317835@sas1-fb8a605c4548.qloud-c.yandex.net>
	<20190217192720.qphwrraj66rht5lj@alap3.anarazel.de>
	<10224751551523791@myt3-c7e5d17fe013.qloud-c.yandex.net>
	<20190304031918.GH1999@paquier.xyz>

Hi Michael,

On 3/4/19 7:19 AM, Michael Paquier wrote:
> On Sat, Mar 02, 2019 at 01:49:51PM +0300, Sergei Kornilov wrote:
>> This might be not the right way, but I can't think of a better way
>> to not switch to a different method than split of lastSourceFailed
>> processing and starting new source. Something like refactoring in
>> first attached patch. I move RequestXLogStreaming logic from
>> lastSourceFailed processing and add new pendingRestartSource
>> indicator.
> 
> OK.  This needs a rather close lookup, and I am not actually sure that
> you even need pendingRestartSource.  Please let me a couple of days
> before coming back to you on 0001.
> 
>> Second patch is mostly the same as previous version but uses new
>> pendingRestartSource mechanism instead of lastSourceFailed.
> 
> This, on the other hand, looks like the implementation we are looking
> for based on the discussions which happened until now to have the
> startup process handle the shutdown and restart of the WAL receiver.

Do you know when you'll have a chance to revisit this?

Regards,
-- 
-David
david@pgmasters.net




view thread (77+ messages)  latest in thread

Message-ID: <bb9961f5-3f75-41d0-a4cb-adf7741ea7dc@pgmasters.net>
Permalink:  ../bb9961f5-3f75-41d0-a4cb-adf7741ea7dc@pgmasters.net/
Also on:    postgresql.org/message-id/bb9961f5-3f75-41d0-a4cb-adf7741ea7dc@pgmasters.net

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: david@pgmasters.net, michael@paquier.xyz, sk@zsrv.org, andres@anarazel.de, horiguchi.kyotaro@lab.ntt.co.jp
  Subject: Re: Re: allow online change primary_conninfo
  In-Reply-To: <bb9961f5-3f75-41d0-a4cb-adf7741ea7dc@pgmasters.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox