pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Jesper Pedersen <jesper.pedersen@redhat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: David Rowley <david.rowley@2ndquadrant.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: POC: converting Lists into arrays
Date: Mon, 1 Jul 2019 15:18:02 -0400
Message-ID: <bbe340c9-76fb-c66d-8a14-73168f0b89b9@redhat.com> (raw)
In-Reply-To: <25178.1562006685@sss.pgh.pa.us>
References: <481.1551390571@sss.pgh.pa.us>
	<24783.1551568303@sss.pgh.pa.us>
	<20190303043424.itzy3ge52xrkpmpr@alap3.anarazel.de>
	<437.1551637744@sss.pgh.pa.us>
	<CA+TgmoZM4c=v0ifR++i09JFtNtnqTq_HkFmbFjwWqbUJffOLmA@mail.gmail.com>
	<12684.1551723095@sss.pgh.pa.us>
	<20190304190612.vgqqsowzkrh22623@alap3.anarazel.de>
	<26464.1551734920@sss.pgh.pa.us>
	<20190304221101.hdg4vj5fo4eewh3b@alap3.anarazel.de>
	<CAKJS1f-pNfoUJrmU8vgD1WrKLqs9WxOVLQ0RpSWu9h6W9RnypA@mail.gmail.com>
	<20190304235402.nod3gbotk2qtd4nh@alap3.anarazel.de>
	<CAKJS1f-yS201hAAmnxcLb2aeTYNZ_A9R1JNXF6hTVXjhHYN7rQ@mail.gmail.com>
	<1131.1551746172@sss.pgh.pa.us>
	<14626.1558745627@sss.pgh.pa.us>
	<29297.1558799327@sss.pgh.pa.us>
	<f078ce63-9e04-0f3e-d200-d7ee66279abe@redhat.com>
	<25178.1562006685@sss.pgh.pa.us>

Hi,

On 7/1/19 2:44 PM, Tom Lane wrote:
> Yup, here's a rebase against HEAD (and I also find that check-world shows
> no problems).

Thanks - no further comments.

>  This is pretty much of a pain to maintain, since it changes
> the API for lnext() which is, um, a bit invasive.  I'd like to make a
> decision pretty quickly on whether we're going to do this, and either
> commit this patch or abandon it.
> 

IMHO it is an improvement over the existing API.

>> There is some unneeded MemoryContext stuff in async.c's
>> pg_listening_channels() which should be cleaned up.
> 
> Yeah, there's a fair amount of follow-on cleanup that could be undertaken
> afterwards, but I've wanted to keep the patch's footprint as small as
> possible for the moment.  Assuming we pull the trigger, I'd then go look
> at removing the planner's duplicative lists+arrays for RTEs and such as
> the first cleanup step.  But thanks for the pointer to async.c, I'll
> check that too.
> 

Yeah, I only called out the async.c change, as that function isn't 
likely to change in any of the follow up patches.

Best regards,
  Jesper





view thread (130+ messages)  latest in thread

Message-ID: <bbe340c9-76fb-c66d-8a14-73168f0b89b9@redhat.com>
Permalink:  ../bbe340c9-76fb-c66d-8a14-73168f0b89b9@redhat.com/
Also on:    postgresql.org/message-id/bbe340c9-76fb-c66d-8a14-73168f0b89b9@redhat.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: jesper.pedersen@redhat.com, tgl@sss.pgh.pa.us, david.rowley@2ndquadrant.com, andres@anarazel.de, robertmhaas@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: POC: converting Lists into arrays
  In-Reply-To: <bbe340c9-76fb-c66d-8a14-73168f0b89b9@redhat.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox