From: Masahiro Ikeda <ikedamsh@oss.nttdata.com>
To: Michael Paquier <michael@paquier.xyz>
To: Drouvot, Bertrand <bertranddrouvot.pg@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Introduce WAIT_EVENT_EXTENSION and WAIT_EVENT_BUFFER_PIN
Date: Fri, 09 Jun 2023 18:20:09 +0900
Message-ID: <bc51ad5e9547615cc195abd67af34a89@oss.nttdata.com> (raw)
In-Reply-To: <ZIK/ksBjsgaiWrK0@paquier.xyz>
References: <20230516010102.jwmsuaoynz6zfqmn@awork3.anarazel.de>
<ZGMRMrrz02v8MGTE@paquier.xyz>
<CA+TgmobtMj42OoAqETwhmiNU3k9LB+MiZhK+qdKg4Jh3Dq-Dag@mail.gmail.com>
<20230517233832.si5zpq3qnxmx3swb@awork3.anarazel.de>
<CA+TgmoaYTd3YN3N3vtXi+X63ePOzAdiKfVYX-BROtpWSdF-Auw@mail.gmail.com>
<ZGaocGfirEt6OXNP@paquier.xyz>
<81290a48-b25c-22a5-31a6-3feff5864fe3@gmail.com>
<4420c7fb5bf0894ce92d6857a8d041ed@oss.nttdata.com>
<ZIJhEhRkAGavghW6@paquier.xyz>
<351810d2-120b-9b90-a680-cce6ac1c0fa7@gmail.com>
<ZIK/ksBjsgaiWrK0@paquier.xyz>
Hi,
On 2023-06-09 13:26, Drouvot, Bertrand wrote:
> Hi,
>
> On 6/9/23 1:15 AM, Michael Paquier wrote:
>> On Thu, Jun 08, 2023 at 10:57:55AM +0900, Masahiro Ikeda wrote:
>>> (Excuse me for cutting in, and this is not directly related to the
>>> thread.)
>>> +1. I'm interested in the feature.
>>>
>>> This is just a example and it probable be useful for other users.
>>> IMO, at
>>> least, it's better to improve the specification that "Extension"
>>> wait event type has only the "Extension" wait event.
>>
>> I hope that nobody would counter-argue you here. In my opinion, we
>> should just introduce an API that allows extensions to retrieve wait
>> event numbers that are allocated by the backend under
>> PG_WAIT_EXTENSION, in a fashion similar to GetNamedLWLockTranche().
>> Say something like:
>> int GetExtensionWaitEvent(const char *wait_event_name);
>
> +1, that's something I've in mind to work on once/if this patch is/get
> committed.
Thanks for replying. If you are ok, I'll try to make a patch
to allow extensions to define custom wait events.
Regards,
--
Masahiro Ikeda
NTT DATA CORPORATION
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: ikedamsh@oss.nttdata.com, michael@paquier.xyz, bertranddrouvot.pg@gmail.com, robertmhaas@gmail.com, andres@anarazel.de, pgsql-hackers@lists.postgresql.org
Subject: Re: Introduce WAIT_EVENT_EXTENSION and WAIT_EVENT_BUFFER_PIN
In-Reply-To: <bc51ad5e9547615cc195abd67af34a89@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox