pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Mark Dilger <hornschnorter@gmail.com>
Cc: Adrien Nayrat <adrien.nayrat@dalibo.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [HACKERS] PATCH: multivariate histograms and MCV lists
Date: Wed, 20 Dec 2017 01:31:18 +0100
Message-ID: <bd60f67c-b7c2-eab4-74d7-28d6bf7ff393@2ndquadrant.com> (raw)
In-Reply-To: <7F76E900-9A20-4640-A431-83B0602C3213@gmail.com>
References: <dfdac334-9cf2-2597-fb27-f0fb3753f435@2ndquadrant.com>
	<31ee8686-6d62-7f10-4129-7580ec74a710@dalibo.com>
	<b3688203-7c5d-2d7e-58b6-a6bb04f29b5c@2ndquadrant.com>
	<340ffd44-2d67-d39d-e54f-5a97a842cd3a@2ndquadrant.com>
	<b3e23e18-afbb-2a39-8e15-fe0a6c39a128@2ndquadrant.com>
	<67EAB5B3-F9FB-4753-8102-4D77DCFFFCD4@gmail.com>
	<cf43d6de-617f-83c0-8c14-740c3fa23795@2ndquadrant.com>
	<B3AF05D4-A312-4988-BC5F-256E756C43CB@gmail.com>
	<63aa9ad9-cebd-a842-ea50-7f99b94443cd@2ndquadrant.com>
	<0938F717-F4A0-4568-83B4-80A19887EA25@gmail.com>
	<933aab0d-fd36-9494-e0eb-79ebc4f57ef5@2ndquadrant.com>
	<e410d526-ab5c-0ca3-672b-6a1876a42ea8@2ndquadrant.com>
	<7F76E900-9A20-4640-A431-83B0602C3213@gmail.com>

Hi,

On 12/19/2017 08:17 PM, Mark Dilger wrote:
> 
> I tested your latest patches on my mac os x laptop and got one test
> failure due to the results of 'explain' coming up differently.  For the record,
> I followed these steps:
> 
> cd postgresql/
> git pull
> # this got my directory up to 8526bcb2df76d5171b4f4d6dc7a97560a73a5eff with no local changes
> patch -p 1 < ../0001-multivariate-MCV-lists.patch
> patch -p 1 < ../0002-multivariate-histograms.patch
> ./configure --prefix=/Users/mark/master/testinstall --enable-cassert --enable-tap-tests --enable-depend && make -j4 && make check-world
> 

Yeah, those steps sounds about right.

Apparently this got broken by ecc27d55f4, although I don't quite
understand why - but it works fine before. Can you try if it works fine
on 9f4992e2a9 and fails with ecc27d55f4?

regards

-- 
Tomas Vondra                  http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services




view thread (167+ messages)  latest in thread

Message-ID: <bd60f67c-b7c2-eab4-74d7-28d6bf7ff393@2ndquadrant.com>
Permalink:  ../bd60f67c-b7c2-eab4-74d7-28d6bf7ff393@2ndquadrant.com/
Also on:    postgresql.org/message-id/bd60f67c-b7c2-eab4-74d7-28d6bf7ff393@2ndquadrant.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tomas.vondra@2ndquadrant.com, hornschnorter@gmail.com, adrien.nayrat@dalibo.com
  Subject: Re: [HACKERS] PATCH: multivariate histograms and MCV lists
  In-Reply-To: <bd60f67c-b7c2-eab4-74d7-28d6bf7ff393@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox