pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Vik Fearing <vik.fearing@2ndquadrant.com>
To: Edmund Horner <ejrh00@gmail.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: PATCH: psql tab completion for SELECT
Date: Mon, 5 Mar 2018 16:48:38 +0100
Message-ID: <be461d2b-5bd6-d114-4262-ef9e6f88b1e5@2ndquadrant.com> (raw)
In-Reply-To: <CAMyN-kBdOJAoFN4f70WY5o_eMeCqnPWVqh9dnS8mFVBaa6z-1A@mail.gmail.com>
References: <CAMyN-kB_xrU4iYdcF1j=tijgO1DSyjtb3j96O4UEj91XZrZcMg@mail.gmail.com>
	<CAMyN-kCr6aUFaE=ov+_r=b4nS_ihtmJ8-MLMoomZGWdNFgMaVw@mail.gmail.com>
	<F9466A55-8F16-4DC2-BAE8-6386870A3C3C@anarazel.de>
	<CAMyN-kC65Xdn3Y5A+muYWMAR50gk-oCABcyZ809wuV0x9_nsJQ@mail.gmail.com>
	<882D6617-FA16-4C56-8FE0-884BCBBE5A4C@anarazel.de>
	<CAMyN-kAJX9fkzm1aFE5sp4se9t1c+p1e1JJGc_MXerxHUK9qoQ@mail.gmail.com>
	<2738.1516234038@sss.pgh.pa.us>
	<3a919958-e508-3b66-686f-44a7937fb6e7@2ndquadrant.com>
	<CAMyN-kDBXUAmoRb1oYaSMQDUA3=xccEzQncRBMywt4KodPdwTw@mail.gmail.com>
	<cbd1e86b-88c9-edc1-8a88-66df58d8cd39@2ndquadrant.com>
	<CAMyN-kBY=cPuD-LXTZndS6biWDYUMScd8N=vGeArPU+bztP5VA@mail.gmail.com>
	<24314.1520190408@sss.pgh.pa.us>
	<13e049ac-ae0f-02a1-8979-69fd56dd31d6@2ndquadrant.com>
	<CAMyN-kBdOJAoFN4f70WY5o_eMeCqnPWVqh9dnS8mFVBaa6z-1A@mail.gmail.com>

On 03/05/2018 11:33 AM, Edmund Horner wrote:
> On 5 March 2018 at 21:46, Vik Fearing <vik.fearing@2ndquadrant.com> wrote:
>> Tab completion on functions in SELECT (a subset of this thread's patch)
>> is quite important to me personally.  I will work on this in the coming
>> days.
> 
> It's something I've missed numerous times in the last few months at
> work.  I guess I should really be running a psql with my own
> preliminary patches applied; but I'm only a novice pgsql-hacker, and
> easily default to using the official one.
> 
> If you are going to work on a patch just for functions, you should
> probably make it a SchemaQuery.  I did not find a way to support
> schema-qualified functions in a query that also returned column names.

I meant that I was going to work on your patch, with you, to quickly get
this in v11.
-- 
Vik Fearing                                          +33 6 46 75 15 36
http://2ndQuadrant.fr     PostgreSQL : Expertise, Formation et Support




view thread (47+ messages)  latest in thread

Message-ID: <be461d2b-5bd6-d114-4262-ef9e6f88b1e5@2ndquadrant.com>
Permalink:  ../be461d2b-5bd6-d114-4262-ef9e6f88b1e5@2ndquadrant.com/
Also on:    postgresql.org/message-id/be461d2b-5bd6-d114-4262-ef9e6f88b1e5@2ndquadrant.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: vik.fearing@2ndquadrant.com, ejrh00@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: PATCH: psql tab completion for SELECT
  In-Reply-To: <be461d2b-5bd6-d114-4262-ef9e6f88b1e5@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox