pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@enterprisedb.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: Pavan Deolasee <pavan.deolasee@gmail.com>
Cc: Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
Cc: Tomas Vondra <tomas.vondra@2ndquadrant.com>
Cc: Tatsuo Ishii <ishii@sraoss.co.jp>
Cc: lubennikovaav@gmail.com, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: ibrar.ahmad@gmail.com
Subject: Re: COPY FREEZE and setting PD_ALL_VISIBLE/visibility map bits
Date: Sat, 23 Jan 2021 04:58:06 +0100
Message-ID: <bf4f54d5-6f23-99d9-89a6-ee143c871085@enterprisedb.com> (raw)
In-Reply-To: <1254689.1611360614@sss.pgh.pa.us>
References: <CABOikdN-ptGv0mZntrK2Q8OtfUuAjqaYMGmkdU1dCKFtUxVLrg@mail.gmail.com>
	<CALtqXTfpEOiyJchYQoUKw9pvEPhVgnkxL=JvKNj57BTxva8bTA@mail.gmail.com>
	<160382617166.1204.475752573208579406.pgcf@coridan.postgresql.org>
	<20201028.144653.966121790856478893.t-ishii@sraoss.co.jp>
	<20201030004252.d63rwclys4bniluu@development>
	<1d2e0f4a-6ab8-10f1-c177-af97475df001@postgrespro.ru>
	<20201102144453.tumlk7qhw3gzn2dk@development>
	<7e6a006f-c59a-93fc-3ddf-f9c661319bc8@2ndquadrant.com>
	<75f3760f-1077-07c1-aea4-975d5c127d6d@postgrespro.ru>
	<f6e0af44-b147-d27f-cc21-2404b4f11f0e@enterprisedb.com>
	<93b767d6-4cde-7326-8de4-d71d81817c16@postgrespro.ru>
	<8669d452-d078-bdf9-5a62-6f1acd55f3c6@enterprisedb.com>
	<58359211-c505-1ee6-c5fd-78db84afb46f@postgrespro.ru>
	<13a5b2dc-4fe9-d4a6-01df-d2c7bba8fd2c@enterprisedb.com>
	<692cd1f2-0aba-a959-f142-b9851691b35b@enterprisedb.com>
	<CABOikdObeumXbrHAvx=KPfKrhTyi2EhgaBOou7LjaCGYeOzKyg@mail.gmail.com>
	<1254689.1611360614@sss.pgh.pa.us>



On 1/23/21 1:10 AM, Tom Lane wrote:
> Pavan Deolasee <pavan.deolasee@gmail.com> writes:
>> On Mon, Jan 18, 2021 at 3:02 AM Tomas Vondra <tomas.vondra@enterprisedb.com>
>> wrote:
>>> Pushed. Thanks everyone for the effort put into this patch. The first
>>> version was sent in 2015, so it took quite a bit of time.
> 
>> Thanks Tomas, Anastasia and everyone else who worked on the patch and
>> ensured that it gets into the tree.
> 
> Buildfarm results suggest that the test case is unstable under
> CLOBBER_CACHE_ALWAYS:
> 
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=hyrax&dt=2021-01-19%2020%3A27%3A46
> 
> This might mean an actual bug, or just that the test isn't robust.
> 

Yeah :-( It seems I've committed the v5 patch, not the v7 addressing 
exactly this issue (which I've actually pointed out and asked to be 
fixed). Oh well ... I'll get this fixed tomorrow - I have the fix, and I 
have verified that it passes with CLOBBER_CACHE_ALWAYS, but pushing it 
at 5AM does not seem like a good idea.

regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company





view thread (71+ messages)  latest in thread

Message-ID: <bf4f54d5-6f23-99d9-89a6-ee143c871085@enterprisedb.com>
Permalink:  ../bf4f54d5-6f23-99d9-89a6-ee143c871085@enterprisedb.com/
Also on:    postgresql.org/message-id/bf4f54d5-6f23-99d9-89a6-ee143c871085@enterprisedb.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tomas.vondra@enterprisedb.com, tgl@sss.pgh.pa.us, pavan.deolasee@gmail.com, a.lubennikova@postgrespro.ru, tomas.vondra@2ndquadrant.com, ishii@sraoss.co.jp, pgsql-hackers@lists.postgresql.org, ibrar.ahmad@gmail.com
  Subject: Re: COPY FREEZE and setting PD_ALL_VISIBLE/visibility map bits
  In-Reply-To: <bf4f54d5-6f23-99d9-89a6-ee143c871085@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox