pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Unify DLSUFFIX on Darwin
Date: Wed, 6 Jul 2022 08:08:07 +0200
Message-ID: <c25ede4e-d1ad-5d0c-e2eb-a3752063c399@enterprisedb.com> (raw)
In-Reply-To: <348725.1656080031@sss.pgh.pa.us>
References: <bcc45f78-e3c3-8fb3-7c42-5371b48b5266@enterprisedb.com>
	<3336874.1655905520@sss.pgh.pa.us>
	<f64debe0-0045-9a7b-6af8-6122cc6ce18d@enterprisedb.com>
	<348725.1656080031@sss.pgh.pa.us>

On 24.06.22 16:13, Tom Lane wrote:
> [ thinks for a bit... ]  Might be worth double-checking that pg_upgrade
> doesn't get confused in a cross-version upgrade.  A quick grep doesn't
> find that it refers to DLSUFFIX anywhere, but it definitely does pay
> attention to extensions' shared library names.

pg_upgrade just checks that it can "LOAD" whatever it finds in probin. 
So this will work if extensions use the recommended extension-free file 
names.  If they don't, they should get a clean failure.

If this becomes a problem in practice, we could make pg_dump 
automatically adjust the probin on upgrade from an old version.

I have committed this now.  We can see how it goes.





view thread (6+ messages)

Message-ID: <c25ede4e-d1ad-5d0c-e2eb-a3752063c399@enterprisedb.com>
Permalink:  ../c25ede4e-d1ad-5d0c-e2eb-a3752063c399@enterprisedb.com/
Also on:    postgresql.org/message-id/c25ede4e-d1ad-5d0c-e2eb-a3752063c399@enterprisedb.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@enterprisedb.com, tgl@sss.pgh.pa.us
  Subject: Re: Unify DLSUFFIX on Darwin
  In-Reply-To: <c25ede4e-d1ad-5d0c-e2eb-a3752063c399@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox