pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Shinoda, Noriyoshi (PN Japan FSIP) <noriyoshi.shinoda@hpe.com>
To: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: rjuju123@gmail.com <rjuju123@gmail.com>
Cc: tgl@sss.pgh.pa.us <tgl@sss.pgh.pa.us>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Subject: Re: Improve logging when using Huge Pages
Date: Tue, 2 Nov 2021 23:35:18 +0900
Message-ID: <c26d22f4-2ab9-25dc-810c-e8cce067b422@oss.nttdata.com> (raw)
In-Reply-To: <TU4PR8401MB11527AEB859A4C70F060EC65EE8B9@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM>
References: <TU4PR8401MB1152B1A4158D609472ABD51DEEA09@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM>
	<80872660-ad16-3040-0a25-bd741faa5fc0@oss.nttdata.com>
	<20210922002322.GS831@telsasoft.com>
	<20210927.114023.1519840069762071193.horikyota.ntt@gmail.com>
	<TU4PR8401MB11529A0C57CEDCCBC39050EDEEA79@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM>
	<20211022023815.GI741@telsasoft.com>
	<TU4PR8401MB11529CCEE0FCC07EEE9F8FA7EE859@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM>
	<CAD21AoCp6mbAvrXTTxcKrseYccsCjXFDdr3Vo+natFznpNkNBA@mail.gmail.com>
	<64f12586-023b-c6ed-46a8-5251cc81e920@oss.nttdata.com>
	<TU4PR8401MB11527AEB859A4C70F060EC65EE8B9@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM>



On 2021/11/02 18:31, Shinoda, Noriyoshi (PN Japan FSIP) wrote:
> Fujii-san, Sawada-san,
> 
> Thank you for your comment.
> 
>> Also, with the patch, the log message is emitted also during initdb and starting up in single user mode:
> 
> Certainly the log output when executing the initdb command was a noise.
> The attached patch reflects the comments and uses IsPostmasterEnvironment to suppress the output message.

Thanks for updating the patch!

+		ereport(IsPostmasterEnvironment ? LOG : NOTICE, (errmsg("Anonymous shared memory was allocated without huge pages.")));

This change causes the log message to be output with NOTICE level
even when IsPostmasterEnvironment is false. But do we really want
to log that NOTICE message in that case? Instead, isn't it better
to just output the log message with LOG level only when
IsPostmasterEnvironment is true?


Justin and I posted other comments upthread. Could you consider
whether it's worth applying those comments to the patch?


Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION





view thread (93+ messages)  latest in thread

Message-ID: <c26d22f4-2ab9-25dc-810c-e8cce067b422@oss.nttdata.com>
Permalink:  ../c26d22f4-2ab9-25dc-810c-e8cce067b422@oss.nttdata.com/
Also on:    postgresql.org/message-id/c26d22f4-2ab9-25dc-810c-e8cce067b422@oss.nttdata.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: masao.fujii@oss.nttdata.com, noriyoshi.shinoda@hpe.com, sawada.mshk@gmail.com, rjuju123@gmail.com, tgl@sss.pgh.pa.us, horikyota.ntt@gmail.com, pryzby@telsasoft.com
  Subject: Re: Improve logging when using Huge Pages
  In-Reply-To: <c26d22f4-2ab9-25dc-810c-e8cce067b422@oss.nttdata.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox