From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Add .editorconfig
Date: Wed, 11 Dec 2019 17:28:09 +0100
Message-ID: <c926ec2a-cf4b-933a-8471-d08e77ddd689@2ndquadrant.com> (raw)
In-Reply-To: <BCBA36BB-7969-478A-8267-0BA75249AAC9@yesql.se>
References: <273cb788-bbb2-ff34-ad6f-5192b44e5049@2ndquadrant.com>
<BCBA36BB-7969-478A-8267-0BA75249AAC9@yesql.se>
On 2019-12-11 17:09, Daniel Gustafsson wrote:
>> On 11 Dec 2019, at 17:00, Peter Eisentraut <peter.eisentraut@2ndquadrant.com> wrote:
>>
>> There were a couple of recent threads that wanted to add an .editorconfig file but never actually ended up doing so.[0][1] Here is a patch. It is meant to match more or less what's in .dir-locals.el.
>
> +[*.{c,h,l,y,pl,pm}]
>
> What about *.sh?
>
> Not that there is much of Python in the tree, but shouldn't those also be
> covered if we do this?
>
> [*.py]
> indent_style = space
> indent_size = 4
Those were not in the Emacs config either.
I'd be inclined to leave the Python stuff alone, in particular. The
PEP-8 style appears to be universally accepted as the default, so we
don't need to specify it here. We only need to specify what's different
or where no sensible default exists.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, daniel@yesql.se
Subject: Re: Add .editorconfig
In-Reply-To: <c926ec2a-cf4b-933a-8471-d08e77ddd689@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox