pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: Andrey Borodin <amborodin@acm.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Anastasia Lubennikova <lubennikovaav@gmail.com>
Cc: Brad DeJong <Brad.Dejong@infor.com>
Subject: Re: WIP: Covering + unique indexes.
Date: Mon, 27 Feb 2017 08:40:26 -0500
Message-ID: <ca0cb275-0db1-8a40-c5e5-0a1e55bdd4b9@2ndquadrant.com> (raw)
In-Reply-To: <60afe4b8-76b1-64d0-31a3-f5dd016af47e@postgrespro.ru>
References: <56168952.4010101@postgrespro.ru>
	<20160814171131.21390.75752.pgcf@coridan.postgresql.org>
	<f90aa60a-b67f-95b5-d9f5-f5d8ced178c6@postgrespro.ru>
	<CAA4eK1+0jLkz8P7MVsUAj+RHmXm4BWBjV8Cc+_-Hsyhgth9ELA@mail.gmail.com>
	<e3d49c6f-3d66-ffa3-29ad-c4719350f049@postgrespro.ru>
	<CAA4eK1KJNTrfrO9P2cY2kKGejXGMrOYMyAERqa1z7nkM4AzT7Q@mail.gmail.com>
	<8d6b5b13-9c41-bd41-9c86-497e4e6a46ab@postgrespro.ru>
	<CAA4eK1JQ3=Fur6NofmrDXnxm90s39GAxJUCFY3ORAQd9aPozvQ@mail.gmail.com>
	<374642a5-b84e-faab-5d5c-18e558bde195@postgrespro.ru>
	<CAB7nPqSa82oN7jrOVkuSgqcsYZiLYw0heLU5nQ1T_OEQG0LLNA@mail.gmail.com>
	<b950d971-ebe1-fcf2-1e51-2d17209133cf@postgrespro.ru>
	<71e457e5-44e5-b507-16b7-1ced37581804@postgrespro.ru>
	<cf4c2e6a-f58c-eff0-3235-b9ad8cb4ae87@2ndquadrant.com>
	<30b36728-4de8-6d69-5e2c-48e9d959e1ff@postgrespro.ru>
	<CAA4eK1+THMD_G6tb0tpXSy_YKyYFcZCXFvpEOWQai3RqVGfgrQ@mail.gmail.com>
	<60afe4b8-76b1-64d0-31a3-f5dd016af47e@postgrespro.ru>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

On 2/16/17 08:13, Anastasia Lubennikova wrote:
> @@ -629,7 +630,7 @@ static Node *makeRecursiveViewSelect(char *relname, List *aliases, Node *query);
>  
>  	HANDLER HAVING HEADER_P HOLD HOUR_P
>  
> -	IDENTITY_P IF_P ILIKE IMMEDIATE IMMUTABLE IMPLICIT_P IMPORT_P IN_P
> +	IDENTITY_P IF_P ILIKE IMMEDIATE IMMUTABLE IMPLICIT_P IMPORT_P IN_P INCLUDE
>  	INCLUDING INCREMENT INDEX INDEXES INHERIT INHERITS INITIALLY INLINE_P
>  	INNER_P INOUT INPUT_P INSENSITIVE INSERT INSTEAD INT_P INTEGER
>  	INTERSECT INTERVAL INTO INVOKER IS ISNULL ISOLATION

I think your syntax would read no worse, possibly even better, if you
just used the existing INCLUDING keyword.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (217+ messages)  latest in thread

Message-ID: <ca0cb275-0db1-8a40-c5e5-0a1e55bdd4b9@2ndquadrant.com>
Permalink:  ../ca0cb275-0db1-8a40-c5e5-0a1e55bdd4b9@2ndquadrant.com/
Also on:    postgresql.org/message-id/ca0cb275-0db1-8a40-c5e5-0a1e55bdd4b9@2ndquadrant.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@2ndquadrant.com, a.lubennikova@postgrespro.ru, amit.kapila16@gmail.com, michael.paquier@gmail.com, amborodin@acm.org, lubennikovaav@gmail.com, Brad.Dejong@infor.com
  Subject: Re: WIP: Covering + unique indexes.
  In-Reply-To: <ca0cb275-0db1-8a40-c5e5-0a1e55bdd4b9@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox