pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Anton A. Melnikov <a.melnikov@postgrespro.ru>
To: John Naylor <johncnaylorls@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Jeff Davis <pgsql@j-davis.com>
Cc: Ants Aasma <ants.aasma@cybertec.at>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Junwang Zhao <zhjwpku@gmail.com>
Cc: jian he <jian.universality@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Gurjeet Singh <gurjeet@singh.im>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Change GUC hashtable to use simplehash?
Date: Fri, 14 Feb 2025 14:40:52 +0300
Message-ID: <ca93309f-7e06-451e-864c-b985e949e629@postgrespro.ru> (raw)
In-Reply-To: <CANWCAZbVKmE5cvaZQYT8J_yBgt6+tFk5CWm36aoGNvAas4uAqQ@mail.gmail.com>
References: <c95e1821b6a69ec0c40eb0252e037b68a62cdae3.camel@j-davis.com>
	<a3a959f6-14b8-4819-ac04-eaf2aa2e868d@postgrespro.ru>
	<CANWCAZZ0ptKxEyO504OjZOr3Co=WaSEQG5eUU-TFmqD4twhe_w@mail.gmail.com>
	<0647027b-9c9a-4f16-8f7c-3f9f3eb9451e@postgrespro.ru>
	<1520769.1736991361@sss.pgh.pa.us>
	<16198d33-a4e2-46db-b6c3-494367f5816d@postgrespro.ru>
	<CANWCAZbg_pN72nwaeq5pyBOV__Cbs2=HoUPh8NJW3LuF48JkQw@mail.gmail.com>
	<CANWCAZY6rFYeFGGoW_eCVpubQ-QNtkbuumWQts-9FU8Qtc65cQ@mail.gmail.com>
	<4c739718-27d6-44fe-9113-56a251c13275@postgrespro.ru>
	<CANWCAZai=YQNV_VY6tt=pL2RquU2NNr2WQbuj3G8hYeJBeGyyA@mail.gmail.com>
	<f3aa2d45-3b28-41c5-9499-a1bc30e0f8ec@postgrespro.ru>
	<CANWCAZZJ0NqpsW27n3xArpStNhhq1qv6KO3v_mBc8vnxE0WHMw@mail.gmail.com>
	<42304488-65ce-4604-854e-2aaf3bc8f09d@postgrespro.ru>
	<CANWCAZbxVto_L6ynXd4rPNyDbXoJxCTJJQV6zkfFriHEcP-Vxw@mail.gmail.com>
	<5ef9fb1c-2e5a-489e-85f5-ba7ac6159577@postgrespro.ru>
	<CANWCAZbVKmE5cvaZQYT8J_yBgt6+tFk5CWm36aoGNvAas4uAqQ@mail.gmail.com>

Hi, Jhon!

On 14.02.2025 08:17, John Naylor wrote:
> Hi Anton, could you please test if the attached passes for you? This
> seems the simplest way.

Yes, of course. I tested this patch on the current master at 9e17ac997
in the same way and found no valgrind errors.

Moreover, with -O2 build on my PC the nsphash_lookup() has
become fully inlined with this patch and almost two time
faster - 112 asm instructions under the same conditions.
Thanks!

With the best wishes,

-- 
Anton A. Melnikov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company





view thread (103+ messages)  latest in thread

Message-ID: <ca93309f-7e06-451e-864c-b985e949e629@postgrespro.ru>
Permalink:  ../ca93309f-7e06-451e-864c-b985e949e629@postgrespro.ru/
Also on:    postgresql.org/message-id/ca93309f-7e06-451e-864c-b985e949e629@postgrespro.ru

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: a.melnikov@postgrespro.ru, johncnaylorls@gmail.com, tgl@sss.pgh.pa.us, pgsql@j-davis.com, ants.aasma@cybertec.at, hlinnaka@iki.fi, zhjwpku@gmail.com, jian.universality@gmail.com, andres@anarazel.de, gurjeet@singh.im
  Subject: Re: Change GUC hashtable to use simplehash?
  In-Reply-To: <ca93309f-7e06-451e-864c-b985e949e629@postgrespro.ru>
  References: <c95e1821b6a69ec0c40eb0252e037b68a62cdae3.camel@j-davis.com> <CANWCAZZ0ptKxEyO504OjZOr3Co=WaSEQG5eUU-TFmqD4twhe_w@mail.gmail.com> <0647027b-9c9a-4f16-8f7c-3f9f3eb9451e@postgrespro.ru> <1520769.1736991361@sss.pgh.pa.us> <16198d33-a4e2-46db-b6c3-494367f5816d@postgrespro.ru> <CANWCAZbg_pN72nwaeq5pyBOV__Cbs2=HoUPh8NJW3LuF48JkQw@mail.gmail.com> <CANWCAZY6rFYeFGGoW_eCVpubQ-QNtkbuumWQts-9FU8Qtc65cQ@mail.gmail.com> <4c739718-27d6-44fe-9113-56a251c13275@postgrespro.ru> <CANWCAZai=YQNV_VY6tt=pL2RquU2NNr2WQbuj3G8hYeJBeGyyA@mail.gmail.com> <f3aa2d45-3b28-41c5-9499-a1bc30e0f8ec@postgrespro.ru> <CANWCAZZJ0NqpsW27n3xArpStNhhq1qv6KO3v_mBc8vnxE0WHMw@mail.gmail.com> <42304488-65ce-4604-854e-2aaf3bc8f09d@postgrespro.ru> <CANWCAZbxVto_L6ynXd4rPNyDbXoJxCTJJQV6zkfFriHEcP-Vxw@mail.gmail.com> <5ef9fb1c-2e5a-489e-85f5-ba7ac6159577@postgrespro.ru> <CANWCAZbVKmE5cvaZQYT8J_yBgt6+tFk5CWm36aoGNvAas4uAqQ@mail.gmail.com> <ca93309f-7e06-451e-864c-b985e949e629@postgrespro.ru>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox