pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Anton A. Melnikov <a.melnikov@postgrespro.ru>
To: John Naylor <johncnaylorls@gmail.com>
To: Jeff Davis <pgsql@j-davis.com>
Cc: Ants Aasma <ants.aasma@cybertec.at>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: Junwang Zhao <zhjwpku@gmail.com>
Cc: jian he <jian.universality@gmail.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Gurjeet Singh <gurjeet@singh.im>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Change GUC hashtable to use simplehash?
Date: Thu, 19 Dec 2024 03:10:30 +0300
Message-ID: <a3a959f6-14b8-4819-ac04-eaf2aa2e868d@postgrespro.ru> (raw)
In-Reply-To: <CANWCAZYLvWOm-1XLT8wGoXGgNBEV_NPMWJY4gM6cXa7LHVDjtw@mail.gmail.com>
References: <c95e1821b6a69ec0c40eb0252e037b68a62cdae3.camel@j-davis.com>
	<3786e988-0dc6-4feb-866c-ab5215bf2394@iki.fi>
	<CANWCAZbEOdBagWQh9Omb=MiwjGJ88MNd-6ZYhxbwQXWPh0J4hA@mail.gmail.com>
	<611843ead9b111c763420bd09bbcb4a330032f8b.camel@j-davis.com>
	<09924cd6c49935d5e9bba5cd40bec28c605d7c2e.camel@j-davis.com>
	<CANWCAZZY+kZpMQh4OCJ1jrQigh_oCDWrbzWWOPTmJKj+0enR3A@mail.gmail.com>
	<48e8f8bbe0be9c789f98776c7438244ab7a7cc63.camel@j-davis.com>
	<CANwKhkP7pCiW_5fAswLhs71-JKGEz1c1+PC0a_w1fwY4iGMqUA@mail.gmail.com>
	<CANWCAZbXooNxa1oX4+N-QVTknRiiUBs17ai8rcWYihs_g=ShEQ@mail.gmail.com>
	<CANWCAZbg_XeSeY0a_PqWmWqeRATvzTzUNYRLeT+bzs+YQdC92g@mail.gmail.com>
	<CANWCAZbwvp7oUEkbw-xP4L0_S_WNKq-J-ucP4RCNDPJnrakUPw@mail.gmail.com>
	<458350a908d9607f7fc2a15407f4405cc454c970.camel@j-davis.com>
	<CANWCAZYxrJJ4EDw=o5vu_gAs7dS_PK6ry0rqkVu9opGpAJjoQQ@mail.gmail.com>
	<2b0df3af97fac73a40aba16a58837e2cee594b1f.camel@j-davis.com>
	<CANWCAZYLvWOm-1XLT8wGoXGgNBEV_NPMWJY4gM6cXa7LHVDjtw@mail.gmail.com>

Hi!

Found that https://github.com/postgres/postgres/commit/0aba2554409ee3251d7558567edd114d8ed36dcc
produces a valgrind error in initdb.
Such a steps:
CPPFLAGS="-DUSE_VALGRIND -Og"  ./configure --enable-debug --enable-tap-tests --enable-cassert --with-icu
make ...
valgrind --quiet --exit-on-first-error=yes --error-exitcode=1 --leak-check=no --time-stamp=yes \
  --gen-suppressions=all --trace-children=yes <path-to>/initdb -k -D <path-to>/data

give an error:

running bootstrap script ... ok
performing post-bootstrap initialization ... ==00:00:00:01.856 967784== Conditional jump or move depends on uninitialised value(s)
==00:00:00:01.856 967784==    at 0x2F41F4: fasthash_accum (hashfn_unstable.h:136)
==00:00:00:01.856 967784==    by 0x2F41F4: fasthash_accum_cstring_aligned (hashfn_unstable.h:247)
==00:00:00:01.856 967784==    by 0x2F41F4: fasthash_accum_cstring (hashfn_unstable.h:271)
==00:00:00:01.856 967784==    by 0x2F41F4: spcachekey_hash (namespace.c:268)
==00:00:00:01.856 967784==    by 0x2F479F: nsphash_lookup (simplehash.h:836)
==00:00:00:01.856 967784==    by 0x2F479F: spcache_insert (namespace.c:379)
==00:00:00:01.856 967784==    by 0x2F533C: cachedNamespacePath (namespace.c:4236)
==00:00:00:01.856 967784==    by 0x2F5425: recomputeNamespacePath (namespace.c:4294)
==00:00:00:01.856 967784==    by 0x2F5516: RelnameGetRelid (namespace.c:875)
==00:00:00:01.856 967784==    by 0x2F6CD5: RangeVarGetRelidExtended (namespace.c:524)
==00:00:00:01.856 967784==    by 0x2DD1C7: objectNamesToOids (aclchk.c:701)
==00:00:00:01.856 967784==    by 0x2E2A9D: ExecuteGrantStmt (aclchk.c:441)
==00:00:00:01.856 967784==    by 0x61FF62: ProcessUtilitySlow (utility.c:1816)
==00:00:00:01.856 967784==    by 0x61E948: standard_ProcessUtility (utility.c:973)
==00:00:00:01.856 967784==    by 0x61EC1A: ProcessUtility (utility.c:530)
==00:00:00:01.856 967784==    by 0x61C059: PortalRunUtility (pquery.c:1158)
==00:00:00:01.856 967784==
{
    <insert_a_suppression_name_here>
    Memcheck:Cond
    fun:fasthash_accum
    fun:fasthash_accum_cstring_aligned
    fun:fasthash_accum_cstring
    fun:spcachekey_hash
    fun:nsphash_lookup
    fun:spcache_insert
    fun:cachedNamespacePath
    fun:recomputeNamespacePath
    fun:RelnameGetRelid
    fun:RangeVarGetRelidExtended
    fun:objectNamesToOids
    fun:ExecuteGrantStmt
    fun:ProcessUtilitySlow
    fun:standard_ProcessUtility
    fun:ProcessUtility
    fun:PortalRunUtility
}
==00:00:00:01.856 967784==
==00:00:00:01.856 967784== Exit program on first error (--exit-on-first-error=yes)
child process exited with exit code 1

The current master at b7493e1 also has this error.


With the best regards,

-- 
Anton A. Melnikov
Postgres Professional: http://www.postgrespro.com
The Russian Postgres Company





view thread (103+ messages)  latest in thread

Message-ID: <a3a959f6-14b8-4819-ac04-eaf2aa2e868d@postgrespro.ru>
Permalink:  ../a3a959f6-14b8-4819-ac04-eaf2aa2e868d@postgrespro.ru/
Also on:    postgresql.org/message-id/a3a959f6-14b8-4819-ac04-eaf2aa2e868d@postgrespro.ru

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: a.melnikov@postgrespro.ru, johncnaylorls@gmail.com, pgsql@j-davis.com, ants.aasma@cybertec.at, hlinnaka@iki.fi, zhjwpku@gmail.com, jian.universality@gmail.com, andres@anarazel.de, tgl@sss.pgh.pa.us, gurjeet@singh.im
  Subject: Re: Change GUC hashtable to use simplehash?
  In-Reply-To: <a3a959f6-14b8-4819-ac04-eaf2aa2e868d@postgrespro.ru>
  References: <c95e1821b6a69ec0c40eb0252e037b68a62cdae3.camel@j-davis.com> <CANWCAZbEOdBagWQh9Omb=MiwjGJ88MNd-6ZYhxbwQXWPh0J4hA@mail.gmail.com> <611843ead9b111c763420bd09bbcb4a330032f8b.camel@j-davis.com> <09924cd6c49935d5e9bba5cd40bec28c605d7c2e.camel@j-davis.com> <CANWCAZZY+kZpMQh4OCJ1jrQigh_oCDWrbzWWOPTmJKj+0enR3A@mail.gmail.com> <48e8f8bbe0be9c789f98776c7438244ab7a7cc63.camel@j-davis.com> <CANwKhkP7pCiW_5fAswLhs71-JKGEz1c1+PC0a_w1fwY4iGMqUA@mail.gmail.com> <CANWCAZbXooNxa1oX4+N-QVTknRiiUBs17ai8rcWYihs_g=ShEQ@mail.gmail.com> <CANWCAZbg_XeSeY0a_PqWmWqeRATvzTzUNYRLeT+bzs+YQdC92g@mail.gmail.com> <CANWCAZbwvp7oUEkbw-xP4L0_S_WNKq-J-ucP4RCNDPJnrakUPw@mail.gmail.com> <458350a908d9607f7fc2a15407f4405cc454c970.camel@j-davis.com> <CANWCAZYxrJJ4EDw=o5vu_gAs7dS_PK6ry0rqkVu9opGpAJjoQQ@mail.gmail.com> <2b0df3af97fac73a40aba16a58837e2cee594b1f.camel@j-davis.com> <CANWCAZYLvWOm-1XLT8wGoXGgNBEV_NPMWJY4gM6cXa7LHVDjtw@mail.gmail.com> <a3a959f6-14b8-4819-ac04-eaf2aa2e868d@postgrespro.ru>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox