pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Bruce Momjian <bruce@momjian.us>
Cc: Paul Guo <guopa@vmware.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Brown <michael.brown@discourse.org>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: fdatasync performance problem with large number of DB files
Date: Fri, 19 Mar 2021 12:08:19 +0900
Message-ID: <cb8dc397-3376-3d2e-4be0-b986a1c17e82@oss.nttdata.com> (raw)
In-Reply-To: <ca3983c4-0fb3-a64f-c533-ddba3e36b177@oss.nttdata.com>
References: <CA+hUKGLABi5asn5yFXBrAC0d3dGBN8QHvLq=27sa7thCQV4Z1w@mail.gmail.com>
	<CA+hUKGK0hZ1jBCF6r+J9=CVwpAUTU7EB3_SUp5Owp0zym4eksg@mail.gmail.com>
	<823DAB20-5A5E-4F7B-BF8C-D61FA574DEEA@vmware.com>
	<CA+hUKGJi11x6cHJQNeDnLRvk1GMX18DJQaKFqwCOjgeFnbiVKA@mail.gmail.com>
	<76de0e61-a553-6003-aeec-cb35ada791cf@oss.nttdata.com>
	<CA+hUKGJTERHhpAja3KvwF=0qPTgnFB=QPrR=sHmqWKJ2o2mr2Q@mail.gmail.com>
	<52453bfc-40fb-7771-05ee-cbd04b6b9b6e@oss.nttdata.com>
	<4CB921E5-772B-42F9-B14D-D310E709E8F2@vmware.com>
	<CA+hUKGLkoO6i2qoP6u9uKPx8SL4MGzMnT+xQJ+p_x3FggH1Z8A@mail.gmail.com>
	<20210318135411.GB8529@momjian.us>
	<20210318140352.GC8529@momjian.us>
	<3d1086bd-0881-e0a3-9f4f-bda608f07fdb@oss.nttdata.com>
	<CA+hUKGJyjpuqYq60=zhoMWL5cCJKR_V9FaJtoZUv6nJCdtkPVA@mail.gmail.com>
	<CA+hUKG+jOK-0ZbCAiTwPx8_ajfRs9cAgkFf4BodfQiE9G+3n1w@mail.gmail.com>
	<ca3983c4-0fb3-a64f-c533-ddba3e36b177@oss.nttdata.com>



On 2021/03/19 11:22, Fujii Masao wrote:
> 
> 
> On 2021/03/19 10:37, Thomas Munro wrote:
>> On Fri, Mar 19, 2021 at 2:16 PM Thomas Munro <thomas.munro@gmail.com> wrote:
>>> PS: For illustration/discussion, I've also attached a "none" patch.  I
>>> also couldn't resist rebasing my "wal" mode patch, which I plan to
>>> propose for PG15 because there is not enough time left for this
>>> release.
>>
>> Erm... I attached the wrong version by mistake.  Here's a better one.

0002 patch looks good to me. Thanks!
I have minor comments.

- * Issue fsync recursively on PGDATA and all its contents, or issue syncfs for
- * all potential filesystem, depending on recovery_init_sync_method setting.
+ * Issue fsync recursively on PGDATA and all its contents, issue syncfs for
+ * all potential filesystem, or do nothing, depending on
+ * recovery_init_sync_method setting.

The comment in SyncDataDirectory() should be updated so that
it mentions "none" method, as the above?

+        This is only safe if all buffered data is known to have been flushed
+        to disk already, for example by a tool such as
+        <application>pg_basebackup</application>.  It is not a good idea to

Isn't it better to add something like "without <literal>--no-sync</literal>"
to "pg_basebackup" part? Which would prevent users from misunderstanding
that pg_basebackup always ensures that whatever options are specified.

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION





view thread (49+ messages)  latest in thread

Message-ID: <cb8dc397-3376-3d2e-4be0-b986a1c17e82@oss.nttdata.com>
Permalink:  ../cb8dc397-3376-3d2e-4be0-b986a1c17e82@oss.nttdata.com/
Also on:    postgresql.org/message-id/cb8dc397-3376-3d2e-4be0-b986a1c17e82@oss.nttdata.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: masao.fujii@oss.nttdata.com, thomas.munro@gmail.com, bruce@momjian.us, guopa@vmware.com, tgl@sss.pgh.pa.us, michael.brown@discourse.org
  Subject: Re: fdatasync performance problem with large number of DB files
  In-Reply-To: <cb8dc397-3376-3d2e-4be0-b986a1c17e82@oss.nttdata.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox