pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feedDoc necessity for superuser privileges to execute pg_import_system_collations()
3+ messages / 2 participants
[nested] [flat]
Commits from this thread:
2021-07-21 90b6c339b2 9c1d56a9b0 df3264e73f fe4941fdfc a8f144bbf0 c601ec2e38 doc: Document that only superusers can use pg_import_system_collations().
* Doc necessity for superuser privileges to execute pg_import_system_collations()
@ 2021-07-19 02:45 torikoshia <torikoshia@oss.nttdata.com>
2021-07-19 04:30 ` Re: Doc necessity for superuser privileges to execute pg_import_system_collations() Fujii Masao <masao.fujii@oss.nttdata.com>
0 siblings, 1 reply; 3+ messages in thread
From: torikoshia @ 2021-07-19 02:45 UTC (permalink / raw)
To: pgsql-hackers
Hi.
It seems that only superusers can execute pg_import_system_collations(),
but this is not mentioned in the manual.
Since other functions that require superuser privileges describe that in
the manual, I think it would be better to do the same for consistency.
Thoughts?
--
Regards,
--
Atsushi Torikoshi
NTT DATA CORPORATION
Attachments:
v1-0001-doc-pg_import_system_collations-needs-superuser.patch (text/x-diff, 579B) download
diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
index ac6347a971..819f2c8914 100644
--- a/doc/src/sgml/func.sgml
+++ b/doc/src/sgml/func.sgml
@@ -26563,6 +26563,7 @@ postgres=# SELECT * FROM pg_walfile_name_offset(pg_stop_backup());
be <literal>pg_catalog</literal>, but that is not a requirement; the
collations could be installed into some other schema as well. The
function returns the number of new collation objects it created.
+ This function is restricted to superusers.
</para></entry>
</row>
</tbody>
* Re: Doc necessity for superuser privileges to execute pg_import_system_collations()
2021-07-19 02:45 Doc necessity for superuser privileges to execute pg_import_system_collations() torikoshia <torikoshia@oss.nttdata.com>
@ 2021-07-19 04:30 ` Fujii Masao <masao.fujii@oss.nttdata.com>
2021-07-21 04:58 ` Re: Doc necessity for superuser privileges to execute pg_import_system_collations() Fujii Masao <masao.fujii@oss.nttdata.com>
0 siblings, 1 reply; 3+ messages in thread
From: Fujii Masao @ 2021-07-19 04:30 UTC (permalink / raw)
To: torikoshia <torikoshia@oss.nttdata.com>; pgsql-hackers
On 2021/07/19 11:45, torikoshia wrote:
> Hi.
>
> It seems that only superusers can execute pg_import_system_collations(), but this is not mentioned in the manual.
>
> Since other functions that require superuser privileges describe that in the manual, I think it would be better to do the same for consistency.
>
> Thoughts?
LGTM.
IMO it's better to back-patch this to v10
where pg_import_system_collations() was added.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Doc necessity for superuser privileges to execute pg_import_system_collations()
2021-07-19 02:45 Doc necessity for superuser privileges to execute pg_import_system_collations() torikoshia <torikoshia@oss.nttdata.com>
2021-07-19 04:30 ` Re: Doc necessity for superuser privileges to execute pg_import_system_collations() Fujii Masao <masao.fujii@oss.nttdata.com>
@ 2021-07-21 04:58 ` Fujii Masao <masao.fujii@oss.nttdata.com>
0 siblings, 0 replies; 3+ messages in thread
From: Fujii Masao @ 2021-07-21 04:58 UTC (permalink / raw)
To: torikoshia <torikoshia@oss.nttdata.com>; pgsql-hackers
On 2021/07/19 13:30, Fujii Masao wrote:
>
>
> On 2021/07/19 11:45, torikoshia wrote:
>> Hi.
>>
>> It seems that only superusers can execute pg_import_system_collations(), but this is not mentioned in the manual.
>>
>> Since other functions that require superuser privileges describe that in the manual, I think it would be better to do the same for consistency.
>>
>> Thoughts?
>
> LGTM.
>
> IMO it's better to back-patch this to v10
> where pg_import_system_collations() was added.
Pushed. Thanks!
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2021-07-21 04:58 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-07-19 02:45 Doc necessity for superuser privileges to execute pg_import_system_collations() torikoshia <torikoshia@oss.nttdata.com>
2021-07-19 04:30 ` Fujii Masao <masao.fujii@oss.nttdata.com>
2021-07-21 04:58 ` Fujii Masao <masao.fujii@oss.nttdata.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox