pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Julien Rouhaud <rjuju123@gmail.com>
Cc: Justin Pryzby <pryzby@telsasoft.com>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Tharakan, Robins <tharar@amazon.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: track_planning causing performance regression
Date: Wed, 7 Jul 2021 21:57:37 +0900
Message-ID: <cef9be18-161c-98b9-ed0d-a23dc973df49@oss.nttdata.com> (raw)
In-Reply-To: <CAOBaU_ZxTGMapnWTCGaEiAHochUjzEB5XQN3hqbuf0xspDwSbg@mail.gmail.com>
References: <646e5cae-5e8b-feaa-43dc-014bf355bf08@oss.nttdata.com>
	<20210418233615.GB7256@telsasoft.com>
	<d4cb31e2-d43f-0811-8f10-cf8e2f052e5e@oss.nttdata.com>
	<20210419145545.GF7256@telsasoft.com>
	<b86e33bf-d549-db6b-f50b-3cb077807a71@oss.nttdata.com>
	<20210421145338.GT7256@telsasoft.com>
	<f2aa2d6a-3b78-0526-4ca5-8ace10eb745e@oss.nttdata.com>
	<20210421154007.GU7256@telsasoft.com>
	<20210629020918.GE21248@telsasoft.com>
	<CAOBaU_bg0OcRUykMP=_XY7tsBfjtq1NW=JeO5=p=QRg8hXAT1A@mail.gmail.com>
	<20210629024535.GG21248@telsasoft.com>
	<CAOBaU_YJUNCPuEAciSmFBS0EJ16Qa_pDH3mLjSpUnG4FtaSbzg@mail.gmail.com>
	<c162e1b3-08b0-2216-8e9e-80733d4a1a9b@oss.nttdata.com>
	<CAOBaU_ZxTGMapnWTCGaEiAHochUjzEB5XQN3hqbuf0xspDwSbg@mail.gmail.com>



On 2021/07/07 18:09, Julien Rouhaud wrote:
> On Thu, Jul 1, 2021 at 4:28 PM Fujii Masao <masao.fujii@oss.nttdata.com> wrote:
>>
>> I'm fine with this. So what about the following diff? I added <structname> tag.
>>
>>          <varname>pg_stat_statements.track_planning</varname> controls whether
>>          planning operations and duration are tracked by the module.
>>          Enabling this parameter may incur a noticeable performance penalty,
>> -      especially when a fewer kinds of queries are executed on many
>> -      concurrent connections.
>> +      especially when statements with identical query structure are executed
>> +      by many concurrent connections which compete to update a small number of
>> +      <structname>pg_stat_statements</structname> entries.
>>          The default value is <literal>off</literal>.
>>          Only superusers can change this setting.
> 
> It seems perfect, thanks!

Pushed. Thanks!

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION





view thread (64+ messages)  latest in thread

Message-ID: <cef9be18-161c-98b9-ed0d-a23dc973df49@oss.nttdata.com>
Permalink:  ../cef9be18-161c-98b9-ed0d-a23dc973df49@oss.nttdata.com/
Also on:    postgresql.org/message-id/cef9be18-161c-98b9-ed0d-a23dc973df49@oss.nttdata.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: masao.fujii@oss.nttdata.com, rjuju123@gmail.com, pryzby@telsasoft.com, pavel.stehule@gmail.com, pg@bowt.ie, tharar@amazon.com
  Subject: Re: track_planning causing performance regression
  In-Reply-To: <cef9be18-161c-98b9-ed0d-a23dc973df49@oss.nttdata.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox