pg.ddx.io pgsql-hackers@postgresql.org mailing list archive help / color / mirror / Atom feed From: David Steele <david@pgmasters.net>
To: Anastasia Lubennikova <a.lubennikova@postgrespro.ru>
Cc: Peter Geoghegan <pg@bowt.ie>
Cc: Andres Freund <andres@anarazel.de>
Cc: Teodor Sigaev <teodor@sigaev.ru>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Cc: Anastasia Lubennikova <lubennikovaav@gmail.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Aleksander Alekseev <a.alekseev@postgrespro.ru>
Subject: Re: WIP: Covering + unique indexes.
Date: Sat, 8 Apr 2017 10:02:09 -0400
Message-ID: <cf645aea-935f-4bd7-c8e8-ee609909de8c@pgmasters.net> (raw )
In-Reply-To: <CAH2-Wzm9y59h2m6iZjM4fpdUP5r4bsRVzGbN2gTRCO1j4nZmtw@mail.gmail.com >
References: <56168952.4010101@postgrespro.ru >
<46e1f13e-6887-3851-a525-f046029341eb@postgrespro.ru >
<20170324124709.22419.51178.pgcf@coridan.postgresql.org >
<c1f7c059-597f-44e8-7308-73d76ffd493c@sigaev.ru >
<20170330191138.zawsxgsxnt2qy2as@alap3.anarazel.de >
<a976fff4-29a9-c799-5c2d-19a371031325@postgrespro.ru >
<CAH2-WzkT-MeSnHozqoxmmNthVRK9O06rKjCyZZeUri0X41imvw@mail.gmail.com >
<1cd37c03-fedf-4b35-75b5-711e984e240d@postgrespro.ru >
<CAH2-Wzm9y59h2m6iZjM4fpdUP5r4bsRVzGbN2gTRCO1j4nZmtw@mail.gmail.com >
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
On 4/4/17 2:47 PM, Peter Geoghegan wrote:
>
> At the very least, you should change comments to note the issue. I
> think it's highly unlikely that this could ever result in a failure to
> find a split point, which there are many defenses against already, but
> I think I would find that difficult to prove. The intent of the code
> is almost as important as the code, at least in my opinion.
This submission as been Returned with Feedback. Please feel free to
resubmit to a future commitfest.
--
-David
david@pgmasters.net
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
view thread (217+ messages) latest in thread
Message-ID: <cf645aea-935f-4bd7-c8e8-ee609909de8c@pgmasters.net>
Permalink: ../cf645aea-935f-4bd7-c8e8-ee609909de8c@pgmasters.net/
Also on: postgresql.org/message-id/cf645aea-935f-4bd7-c8e8-ee609909de8c@pgmasters.net
copy link · copy postgr.es
reply Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: david@pgmasters.net, a.lubennikova@postgrespro.ru, pg@bowt.ie, andres@anarazel.de, teodor@sigaev.ru, lubennikovaav@gmail.com, peter.eisentraut@2ndquadrant.com, a.alekseev@postgrespro.ru
Subject: Re: WIP: Covering + unique indexes.
In-Reply-To: <cf645aea-935f-4bd7-c8e8-ee609909de8c@pgmasters.net>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox