pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Andres Freund <andres@anarazel.de>
Cc: Masahiko Sawada <masahiko.sawada@2ndquadrant.com>
Cc: Sergei Kornilov <sk@zsrv.org>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: base backup client as auxiliary backend process
Date: Sat, 22 Feb 2020 16:12:27 +0100
Message-ID: <d12686c6-7566-8190-8fb0-af4927e8e4fe@2ndquadrant.com> (raw)
In-Reply-To: <e8f86ba5-48f1-a80a-7f1d-b76bcb9c5c47@2ndquadrant.com>
References: <20191107041630.GK1768@paquier.xyz>
	<4792e456-d75f-8e6a-2d47-34b8f78c266f@2ndquadrant.com>
	<116725031573825947@iva1-ef4837f8671e.qloud-c.yandex.net>
	<8d8c851a-c951-f98e-22c2-f62621c32d3b@2ndquadrant.com>
	<CA+fd4k4BcYrYucNfTnK-CQX3+jsG+PRPEhHAUSo-W4P0Lec57A@mail.gmail.com>
	<4c79f835-b443-7b02-9097-aa1a40f46be9@2ndquadrant.com>
	<CA+fd4k4dM0iEPLxyVyme2RAFsn8SUgrNtBJOu81YqTY4V+nqZA@mail.gmail.com>
	<7925a361-d48c-db03-30b4-fcd331ef7f02@2ndquadrant.com>
	<CA+fd4k4A9hadga4AtyKfxQMgZ9DMzPsV=NAvCcMVEjEZye8vXw@mail.gmail.com>
	<5686daaa-e39f-3814-7ece-e96462f20616@2ndquadrant.com>
	<20200203124731.ykmyps26ohan4fsx@alap3.anarazel.de>
	<e8f86ba5-48f1-a80a-7f1d-b76bcb9c5c47@2ndquadrant.com>

On 2020-02-17 18:42, Peter Eisentraut wrote:
> On 2020-02-03 13:47, Andres Freund wrote:
>> Comment:
>>
>> - It'd be good to split out the feature independent refactorings, like
>>     the introduction of InitControlFile(), into their own commit. Right
>>     now it's hard to separate out what should just should be moved code,
>>     and what should be behavioural changes. Especially when there's stuff
>>     like just reindenting comments as part of the patch.
> 
> Agreed.  Here are three refactoring patches extracted that seem useful
> on their own.

These have been committed.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services





view thread (40+ messages)  latest in thread

Message-ID: <d12686c6-7566-8190-8fb0-af4927e8e4fe@2ndquadrant.com>
Permalink:  ../d12686c6-7566-8190-8fb0-af4927e8e4fe@2ndquadrant.com/
Also on:    postgresql.org/message-id/d12686c6-7566-8190-8fb0-af4927e8e4fe@2ndquadrant.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@2ndquadrant.com, andres@anarazel.de, masahiko.sawada@2ndquadrant.com, sk@zsrv.org, michael@paquier.xyz
  Subject: Re: base backup client as auxiliary backend process
  In-Reply-To: <d12686c6-7566-8190-8fb0-af4927e8e4fe@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox