pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Arseny Sher <a.sher@postgrespro.ru>
To: Masahiko Sawada <sawada.mshk@gmail.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Flaky vacuum truncate test in reloptions.sql
Date: Wed, 31 Mar 2021 16:39:39 +0300
Message-ID: <d5dd7eaf-0ba1-a18b-1ef2-552196f36a71@postgrespro.ru> (raw)
In-Reply-To: <CAD21AoB+qb-sOY2QeTnGirjh-UvFJj8eANVwQ4CV-r+t1AhxDA@mail.gmail.com>
References: <87tuotr2hh.fsf@ars-thinkpad>
	<YGLOWsO2bV7KLvh7@paquier.xyz>
	<78aad736-c653-92fd-45ac-4482729459c6@postgrespro.ru>
	<CAD21AoB+qb-sOY2QeTnGirjh-UvFJj8eANVwQ4CV-r+t1AhxDA@mail.gmail.com>


On 3/31/21 4:17 PM, Masahiko Sawada wrote:

 > Is it better to add FREEZE to the first "VACUUM reloptions_test;" as 
well?

I don't think this matters much, as it tests the contrary and the 
probability of
successful test passing (in case of theoretical bug making vacuum to 
truncate
non-empty relation) becomes stunningly small. But adding it wouldn't hurt
either.

-- cheers, arseny





view thread (17+ messages)  latest in thread

Message-ID: <d5dd7eaf-0ba1-a18b-1ef2-552196f36a71@postgrespro.ru>
Permalink:  ../d5dd7eaf-0ba1-a18b-1ef2-552196f36a71@postgrespro.ru/
Also on:    postgresql.org/message-id/d5dd7eaf-0ba1-a18b-1ef2-552196f36a71@postgrespro.ru

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: a.sher@postgrespro.ru, sawada.mshk@gmail.com, michael@paquier.xyz, pgsql-hackers@lists.postgresql.org
  Subject: Re: Flaky vacuum truncate test in reloptions.sql
  In-Reply-To: <d5dd7eaf-0ba1-a18b-1ef2-552196f36a71@postgrespro.ru>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox