pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Andres Freund <andres@anarazel.de>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: libpq error message refactoring
Date: Thu, 22 Sep 2022 22:00:00 -0400
Message-ID: <d5dddca7-9bdc-ee18-1ec9-ee21f8302d4a@enterprisedb.com> (raw)
In-Reply-To: <20220922154225.q4rtgzzsq6pd4f5x@awork3.anarazel.de>
References: <7c0232ef-7b44-68db-599d-b327d0640a77@enterprisedb.com>
	<20220922154225.q4rtgzzsq6pd4f5x@awork3.anarazel.de>

On 22.09.22 17:42, Andres Freund wrote:
> This patch has been failing for a while:
> https://cirrus-ci.com/github/postgresql-cfbot/postgresql/commitfest/39/3854
> 
> Interestingly, previously the error only happened when targetting windows, but
> meson also shows it on freebsd.
> 
> It's not the cause of this failure, I think, but doesn't appendPQExpBufferVA
> need to be added to exports.txt?

I don't want to make that function available to users of libpq, just use 
it inside libpq across .c files.  Is there no visibility level for that? 
  Is that also the problem in the freebsd build?






view thread (14+ messages)  latest in thread

Message-ID: <d5dddca7-9bdc-ee18-1ec9-ee21f8302d4a@enterprisedb.com>
Permalink:  ../d5dddca7-9bdc-ee18-1ec9-ee21f8302d4a@enterprisedb.com/
Also on:    postgresql.org/message-id/d5dddca7-9bdc-ee18-1ec9-ee21f8302d4a@enterprisedb.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@enterprisedb.com, andres@anarazel.de
  Subject: Re: libpq error message refactoring
  In-Reply-To: <d5dddca7-9bdc-ee18-1ec9-ee21f8302d4a@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox