pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: David Steele <david@pgmasters.net>
To: Tomas Vondra <tomas.vondra@2ndquadrant.com>
To: Andres Freund <andres@anarazel.de>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions
Date: Fri, 2 Mar 2018 21:08:22 -0500
Message-ID: <d6e896d3-2c1d-8d2f-07cd-9bec37e1ad09@pgmasters.net> (raw)
In-Reply-To: <47ffe720-8255-923d-78fc-a7c4e9011a42@2ndquadrant.com>
References: <5d00346a-b565-7fde-c6da-35f39c72936a@2ndquadrant.com>
	<d72caaf1-a2da-081c-57ea-d30e5f47fd1e@2ndquadrant.com>
	<4d7ed7b8-df43-9b79-b04e-ad4c43ef519c@2ndquadrant.com>
	<d5f226c6-8a45-a9a3-4cb8-6d695b908eae@2ndquadrant.com>
	<ee4278d9-e421-145c-51d8-790a43ebff3d@2ndquadrant.com>
	<20180302011235.k7bxqmktrvgz5tpb@alap3.anarazel.de>
	<e976e0b4-e752-30f9-2025-95282f8f3ba8@2ndquadrant.com>
	<90964101-eef1-68b1-a337-5e5d4bd6e7f0@pgmasters.net>
	<20180302200529.fwiquub5cr3o4gpz@alap3.anarazel.de>
	<f288c9a2-fbad-6245-c061-90042f2d63ea@2ndquadrant.com>
	<20180303010153.myd3f2bcdvqo6ry5@alap3.anarazel.de>
	<ecc17b46-c2e6-5ed4-eb16-eb6bcb0908bd@pgmasters.net>
	<47ffe720-8255-923d-78fc-a7c4e9011a42@2ndquadrant.com>

On 3/2/18 8:54 PM, Tomas Vondra wrote:
> On 03/03/2018 02:37 AM, David Steele wrote:
>> On 3/2/18 8:01 PM, Andres Freund wrote:
>>> On 2018-03-03 02:00:46 +0100, Tomas Vondra wrote:
>>>> That is somewhat misleading, I think. You're right the last version was
>>>> submitted on 2018-01-19, but the next review arrived on 2018-01-31, i.e.
>>>> right at the end of the CF. So it's not like the patch was sitting there
>>>> with unresolved issues. Based on that review the patch was marked as RWF
>>>> and thus not moved to 2018-03 automatically.
>>>
>>> I don't see how this changes anything.
>>
>> I agree that things could be clearer, and Andres has produced a great
>> document that we can build on.  The old one had gotten a bit stale.
>>
>> However, I think it's pretty obvious that a CF entry should be 
>> accompanied with a patch. It sounds like the timing was awkward but
>> you still had 28 days to produce a new patch.
> 
> Based on internal discussion I'm not so sure about the "pretty obvious"
> part. It certainly wasn't that obvious to me, otherwise I'd submit the
> revised patch earlier - hindsight is 20/20.

Indeed it is.  Be assured that nobody takes pleasure in pushing patches,
but we have limited resources and must make some choices.

>> I also notice that you submitted 7 patches in this CF but are
>> reviewing zero.
> 
> I've volunteered to review a couple of patches at the FOSDEM Developer
> Meeting - I thought Stephen was entering that into the CF app, not sure
> where it got lost.

There are plenty of patches that need review, so go for it.

Regards,
-- 
-David
david@pgmasters.net




view thread (536+ messages)  latest in thread

Message-ID: <d6e896d3-2c1d-8d2f-07cd-9bec37e1ad09@pgmasters.net>
Permalink:  ../d6e896d3-2c1d-8d2f-07cd-9bec37e1ad09@pgmasters.net/
Also on:    postgresql.org/message-id/d6e896d3-2c1d-8d2f-07cd-9bec37e1ad09@pgmasters.net

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: david@pgmasters.net, tomas.vondra@2ndquadrant.com, andres@anarazel.de, peter.eisentraut@2ndquadrant.com
  Subject: Re: PATCH: logical_work_mem and logical streaming of large in-progress transactions
  In-Reply-To: <d6e896d3-2c1d-8d2f-07cd-9bec37e1ad09@pgmasters.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox