From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: using explicit_bzero
Date: Mon, 22 Jul 2019 20:11:29 +0200
Message-ID: <d71cbcf8-c12f-2344-cdcf-b680c5ca2d38@2ndquadrant.com> (raw)
In-Reply-To: <20190711011145.GE4500@paquier.xyz>
References: <42d26bde-5d5b-c90d-87ae-6cab875f73be@2ndquadrant.com>
<27860.1561123531@sss.pgh.pa.us>
<26f25674-9c4d-241f-0e74-3fee9860ca13@2ndquadrant.com>
<2b38e01a-0f7c-33f8-d4a9-edfcf85f9e4b@2ndquadrant.com>
<20190624050850.GE1637@paquier.xyz>
<20190711011145.GE4500@paquier.xyz>
On 2019-07-11 03:11, Michael Paquier wrote:
> On Mon, Jun 24, 2019 at 02:08:50PM +0900, Michael Paquier wrote:
>> CreateRole() and AlterRole() can manipulate a password in plain format
>> in memory. The cleanup could be done just after calling
>> encrypt_password() in user.c.
>>
>> Could it be possible to add the new flag in pg_config.h.win32?
>
> While remembering about it... Shouldn't the memset(0) now happening in
> base64.c for the encoding and encoding routines when facing a failure
> use explicit_zero()?
base64.c doesn't know what the data it is dealing with is used for.
That should be the responsibility of the caller, no?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, michael@paquier.xyz, tgl@sss.pgh.pa.us
Subject: Re: using explicit_bzero
In-Reply-To: <d71cbcf8-c12f-2344-cdcf-b680c5ca2d38@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox