pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: ilmari@ilmari.org
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Craig Ringer <craig@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: configure's checks for --enable-tap-tests are insufficient
Date: Tue, 20 Mar 2018 17:23:26 +0000
Message-ID: <d8j1sgepsoh.fsf@dalvik.ping.uio.no> (raw)
In-Reply-To: <30398.1521564644@sss.pgh.pa.us>
References: <516.1521475003@sss.pgh.pa.us>
	<CAMsr+YHe6KXwqQf6pJaQx_Ny2AkeA40i31y6JGDpFJ__ZOKZDQ@mail.gmail.com>
	<8906.1521513602@sss.pgh.pa.us>
	<d8jefkfoufg.fsf@dalvik.ping.uio.no>
	<9696.1521554152@sss.pgh.pa.us>
	<d8ja7v2q10v.fsf@dalvik.ping.uio.no>
	<12134.1521556826@sss.pgh.pa.us>
	<d8j605qpujo.fsf@dalvik.ping.uio.no>
	<30398.1521564644@sss.pgh.pa.us>

Tom Lane <tgl@sss.pgh.pa.us> writes:

> ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes:
>> Tom Lane <tgl@sss.pgh.pa.us> writes:
>>> ilmari@ilmari.org (Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?=) writes:
>>>> I think the other way would be better simpler: we require a complete
>>>> Perl core installation.
>
>>> And you propose to test for that in configure how?
>
>> Good point, I'd overlooked that aspect.  In that case we can't rely on
>> what Debian or others happen to include in their minimal packages, we
>> have to explicitly check for _every_ module we use anywhere in the test
>> suite, core or not (except perhaps pragmas like 'strict' and 'warnings').
>
> That seems like expensive overkill to me, especially since it seems
> unlikely that we'd keep the list up-to-date over time. 

The patches uptread add about 0.2s to a 6.9s configure run here, I don't
consider that very expensive.  We don't add new modules very often, so I
don't think it's much of a maintenance overhead either.

> I just want to test for modules that we know are likely to be omitted
> on popular platforms.  I've proposed testing two that would improve
> the user experience on Red Hat; what's the equivalent minimum set for
> Debian?

On Debian (I've checked the previous and current stable releases, as
well as unstable) the only package required by the TAP tests not in
perl-base is Time::HiRes.  Of the modules required by PL/Perl, Opcode is
not in perl-base either.

BTW, should include the version in the Test::More check, since we only
requie Perl 5.8, but that only shipped Test::More 0.47, while we require
0.97.

- ilmari
-- 
"A disappointingly low fraction of the human race is,
 at any given time, on fire." - Stig Sandbeck Mathisen




view thread (20+ messages)  latest in thread

Message-ID: <d8j1sgepsoh.fsf@dalvik.ping.uio.no>
Permalink:  ../d8j1sgepsoh.fsf@dalvik.ping.uio.no/
Also on:    postgresql.org/message-id/d8j1sgepsoh.fsf@dalvik.ping.uio.no

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: ilmari@ilmari.org, tgl@sss.pgh.pa.us, craig@2ndquadrant.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: configure's checks for --enable-tap-tests are insufficient
  In-Reply-To: <d8j1sgepsoh.fsf@dalvik.ping.uio.no>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox