From: ilmari@ilmari.org
To: Michael Paquier <michael@paquier.xyz>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Sergei Kornilov <sk@zsrv.org>
Cc: pgsql-hackers\@lists.postgresql.org <pgsql-hackers@lists.postgresql.org>
Subject: Re: REINDEX CONCURRENTLY 2.0
Date: Fri, 12 Apr 2019 12:11:12 +0100
Message-ID: <d8jbm1b32cv.fsf@dalvik.ping.uio.no> (raw)
In-Reply-To: <20190412031046.GD2144@paquier.xyz>
References: <20190411132704.GC30766@paquier.xyz>
<20190411134947.GA22043@alvherre.pgsql>
<20190412031046.GD2144@paquier.xyz>
Michael Paquier <michael@paquier.xyz> writes:
> So... I am coming up with the patch attached. I have introduced some
> tests using a trick with CIC to have an invalid index to work on.
I don't have any comments on the code (but the test looks sensible, it's
the same trick I used to discover the issue in the first place).
However, the doc patch lost the trailing paren:
> The recommended recovery
> method in such cases is to drop the index and try again to perform
> - <command>CREATE INDEX CONCURRENTLY</command>. (Another possibility is to rebuild
> - the index with <command>REINDEX</command>. However, since <command>REINDEX</command>
> - does not support concurrent builds, this option is unlikely to seem
> - attractive.)
> + <command>CREATE INDEX CONCURRENTLY</command>. (Another possibility is
> + to rebuild the index with <command>REINDEX INDEX CONCURRENTLY</command>.
> </para>
- ilmari
--
- Twitter seems more influential [than blogs] in the 'gets reported in
the mainstream press' sense at least. - Matt McLeod
- That'd be because the content of a tweet is easier to condense down
to a mainstream media article. - Calle Dybedahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: ilmari@ilmari.org, michael@paquier.xyz, alvherre@2ndquadrant.com, peter.eisentraut@2ndquadrant.com, sk@zsrv.org, pgsql-hackers@lists.postgresql.org
Subject: Re: REINDEX CONCURRENTLY 2.0
In-Reply-To: <d8jbm1b32cv.fsf@dalvik.ping.uio.no>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox