From: Fujii Masao <masao.fujii@oss.nttdata.com>
To: Nathan Bossart <nathandbossart@gmail.com>
To: David Steele <david@pgmasters.net>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: robertmhaas@gmail.com
Cc: pgsql-hackers@postgresql.org
Subject: Re: remove more archiving overhead
Date: Tue, 26 Jul 2022 16:26:23 +0900
Message-ID: <da82c340-ebef-c6e4-60a8-6292b7fe206d@oss.nttdata.com> (raw)
In-Reply-To: <20220708171848.GC2356733@nathanxps13>
References: <20220707182251.GA2255242@nathanxps13>
<ba7e11b0-054d-1d26-bafd-7a2bc97f11f7@pgmasters.net>
<20220707220716.GA2258527@nathanxps13>
<20220708.105652.1551158050191356887.horikyota.ntt@gmail.com>
<44dbf5e4-8eec-da56-daba-755128b3723e@pgmasters.net>
<20220708165450.GA2356733@nathanxps13>
<983e1c05-d479-dec3-b96e-0e5e359f5aa7@pgmasters.net>
<20220708171848.GC2356733@nathanxps13>
On 2022/07/09 2:18, Nathan Bossart wrote:
> On Fri, Jul 08, 2022 at 01:02:51PM -0400, David Steele wrote:
>> I think I wrote this before I'd had enough coffee. "fully persisted to
>> storage" can mean many things depending on the storage (Posix, CIFS, S3,
>> etc.) so I think this is fine. The basic_archive module is there for people
>> who would like implementation details for Posix.
Yes. But some users might want to use basic_archive without any changes.
For them, how about documenting how basic_archive works in basic_archive docs?
I'm just thinking that it's worth exposing the information commented on
the top of basic_archive.c.
Anyway, since the patches look good to me, I pushed them. Thanks a lot!
If necessary, we can keep improving the docs later.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: masao.fujii@oss.nttdata.com, nathandbossart@gmail.com, david@pgmasters.net, horikyota.ntt@gmail.com, robertmhaas@gmail.com
Subject: Re: remove more archiving overhead
In-Reply-To: <da82c340-ebef-c6e4-60a8-6292b7fe206d@oss.nttdata.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox