From: Peter Eisentraut <peter@eisentraut.org>
To: Michael Paquier <michael@paquier.xyz>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Sofia Kopikova <s.kopikova@postgrespro.ru>
Cc: pgsql-hackers@postgresql.org
Subject: Re: Apply PGDLLIMPORT markings to some GUC variables
Date: Mon, 19 Aug 2024 11:20:33 +0200
Message-ID: <da997cd8-4e63-4a4b-ab09-8b51b4d19b2a@eisentraut.org> (raw)
In-Reply-To: <ZsLjrPgdNkyXr7pW@paquier.xyz>
References: <e0b17014-5319-4dd6-91cd-93d9c8fc9539@postgrespro.ru>
<CA+TgmoZ+NDotjPyVWrBJNZvv2XLYnHq3uVkpQRGe5WdaoHxt8A@mail.gmail.com>
<ZsLjrPgdNkyXr7pW@paquier.xyz>
On 19.08.24 08:18, Michael Paquier wrote:
> On Tue, Aug 13, 2024 at 03:00:00PM -0400, Robert Haas wrote:
>> This seems correct to me.
>
> It is not the first time that this happens in recent history. Would
> it be worth automating that? I would guess a TAP test that takes a
> copy of the headers, applies the changes while filtering the few
> exceptions, then compares it to the origin in the tree?
Probably worth thinking about, but it would at least require some kind
of exclude list, because there are exceptions like src/include/common/
/logging.h.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter@eisentraut.org, michael@paquier.xyz, robertmhaas@gmail.com, s.kopikova@postgrespro.ru
Subject: Re: Apply PGDLLIMPORT markings to some GUC variables
In-Reply-To: <da997cd8-4e63-4a4b-ab09-8b51b4d19b2a@eisentraut.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox