pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Vik Fearing <vik@postgresfriends.org>
To: Dave Page <dpage@pgadmin.org>
To: Andres Freund <andres@anarazel.de>
Cc: Matthias van de Meent <boekewurm+postgres@gmail.com>
Cc: PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Tracking last scan time
Date: Fri, 30 Sep 2022 17:58:31 +0200
Message-ID: <dc67fb77-fc83-dc69-e171-0c8fbdd22191@postgresfriends.org> (raw)
In-Reply-To: <CA+OCxowT==feMvVbDaHyTKvcCp8JAHHW1khHCafa-VG3xrhZ1A@mail.gmail.com>
References: <CA+OCxozrVHNFVEPkweUHMZje+t1tfY816d9MZYc6eZwOOusOaQ@mail.gmail.com>
	<20220831162108.qyarvx7edqnobiye@awork3.anarazel.de>
	<CAEze2WiSvToc1bz2OGz+614COShD5H1Z+NLDSwORfT3p975qgA@mail.gmail.com>
	<20220831185629.mrr2jlwjubsy2pvi@awork3.anarazel.de>
	<CAEze2Whn3UG0RHYGXtKfN9BX9m3F53Fh813_FByhC2XF1DErvQ@mail.gmail.com>
	<20220901183540.cyfje2lsiouj4qi4@awork3.anarazel.de>
	<CA+OCxoxkuMF+hkVWDkiQWnjNpjeap=mYMkHzsdSvFxjjBocrZg@mail.gmail.com>
	<20220906155325.an3xesq5o3fq36gt@awork3.anarazel.de>
	<CA+OCxowT==feMvVbDaHyTKvcCp8JAHHW1khHCafa-VG3xrhZ1A@mail.gmail.com>

On 9/7/22 12:03, Dave Page wrote:
> Here's a v4 patch. This reverts to using
> GetCurrentTransactionStopTimestamp() for the last_scan times, and will
> set xactStopTimestamp the first time GetCurrentTransactionStopTimestamp()
> is called, thus avoiding multiple gettimeofday() calls.
> SetCurrentTransactionStopTimestamp() is removed, as is use
> of xactStopTimestamp (except when resetting it to 0).

This patch looks good to me and has much saner behavior than what it 
replaces.

As a matter of process, the oid for the new function should be in the 
8000-9000 range and the catversion should be bumped by the committer.

Marked as Ready for Committer.  Thanks for the patch!
-- 
Vik Fearing





view thread (43+ messages)  latest in thread

Message-ID: <dc67fb77-fc83-dc69-e171-0c8fbdd22191@postgresfriends.org>
Permalink:  ../dc67fb77-fc83-dc69-e171-0c8fbdd22191@postgresfriends.org/
Also on:    postgresql.org/message-id/dc67fb77-fc83-dc69-e171-0c8fbdd22191@postgresfriends.org

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: vik@postgresfriends.org, dpage@pgadmin.org, andres@anarazel.de, boekewurm+postgres@gmail.com, pgsql-hackers@lists.postgresql.org
  Subject: Re: Tracking last scan time
  In-Reply-To: <dc67fb77-fc83-dc69-e171-0c8fbdd22191@postgresfriends.org>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox