From: Daniel Verite <daniel@manitou-mail.org>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Andreas Karlsson <andreas@proxel.se>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Unicode normalization SQL functions
Date: Mon, 17 Feb 2020 20:14:03 +0100
Message-ID: <dd16d2c4-e7cb-4e6d-a92d-40e8dc1cf8a6@manitou-mail.org> (raw)
In-Reply-To: <bba8933e-44ef-761d-55fb-076f2b6b5650@2ndquadrant.com>
One nitpick:
Around this hunk:
- * unicode_normalize_kc - Normalize a Unicode string to NFKC form.
+ * unicode_normalize - Normalize a Unicode string to the specified form.
*
* The input is a 0-terminated array of codepoints.
*
@@ -304,8 +306,10 @@ decompose_code(pg_wchar code, pg_wchar **result, int
*current)
* string is palloc'd instead, and OOM is reported with ereport().
*/
The comment in full says:
/*
* unicode_normalize - Normalize a Unicode string to the specified form.
*
* The input is a 0-terminated array of codepoints.
*
* In frontend, returns a 0-terminated array of codepoints, allocated with
* malloc. Or NULL if we run out of memory. In frontend, the returned
* string is palloc'd instead, and OOM is reported with ereport().
*/
It looks like the 2nd occurrence of "frontend" was meant to be "backend".
Best regards,
--
Daniel Vérité
PostgreSQL-powered mailer: http://www.manitou-mail.org
Twitter: @DanielVerite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: daniel@manitou-mail.org, peter.eisentraut@2ndquadrant.com, andreas@proxel.se
Subject: Re: Unicode normalization SQL functions
In-Reply-To: <dd16d2c4-e7cb-4e6d-a92d-40e8dc1cf8a6@manitou-mail.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox