From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Cc: Bruce Momjian <bruce@momjian.us>
Subject: Re: file cloning in pg_upgrade and CREATE DATABASE
Date: Tue, 17 Jul 2018 12:32:57 +0200
Message-ID: <e15a6c65-267e-6328-734b-620fdf6772c2@2ndquadrant.com> (raw)
In-Reply-To: <20180717065833.GG3388@paquier.xyz>
References: <bc9ca382-b98d-0446-f699-8c5de2307ca7@2ndquadrant.com>
<20180319070636.GA4633@paquier.xyz>
<20180319071415.GB4633@paquier.xyz>
<20180320025849.GB4963@paquier.xyz>
<678999c6-0967-d22a-e7d1-2a3aff83a77b@2ndquadrant.com>
<20180323171650.GI1302@momjian.us>
<4a62b089-ee93-50ee-f3f7-43c67b4c8ea4@2ndquadrant.com>
<0241eae2-2f31-3667-200d-ae0e2293f692@2ndquadrant.com>
<20180717065833.GG3388@paquier.xyz>
On 17.07.18 08:58, Michael Paquier wrote:
> Hm... I am wondering if we actually want the "auto" mode where we make
> the option smarter automatically. I am afraid of users trying to use it
> and being surprised that there is no gain while they expected some. I
> would rather switch that to an on/off switch, which defaults to "off",
> or simply what is available now. huge_pages=try was a bad idea as the
> result is not deterministic, so I would not have more of that...
Why do you think that was a bad idea? Doing the best possible job by
default without requiring explicit configuration in each case seems like
an attractive feature.
> Putting CloneFile and check_reflink in a location that other frontend
> binaries could use would be nice, like pg_rewind.
This could be done in subsequent patches, but the previous iteration of
this patch for CREATE DATABASE integration already showed that each of
those cases needs separate consideration.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@2ndquadrant.com, michael@paquier.xyz, bruce@momjian.us
Subject: Re: file cloning in pg_upgrade and CREATE DATABASE
In-Reply-To: <e15a6c65-267e-6328-734b-620fdf6772c2@2ndquadrant.com>
References: <bc9ca382-b98d-0446-f699-8c5de2307ca7@2ndquadrant.com> <20180319070636.GA4633@paquier.xyz> <20180319071415.GB4633@paquier.xyz> <20180320025849.GB4963@paquier.xyz> <678999c6-0967-d22a-e7d1-2a3aff83a77b@2ndquadrant.com> <20180323171650.GI1302@momjian.us> <4a62b089-ee93-50ee-f3f7-43c67b4c8ea4@2ndquadrant.com> <0241eae2-2f31-3667-200d-ae0e2293f692@2ndquadrant.com> <20180717065833.GG3388@paquier.xyz> <e15a6c65-267e-6328-734b-620fdf6772c2@2ndquadrant.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox