From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Ankit Kumar Pandey <itsankitkp@gmail.com>
To: pgsql-hackers@lists.postgresql.org
Subject: Re: Check return value of pclose() correctly
Date: Tue, 15 Nov 2022 15:52:54 +0100
Message-ID: <e185b889-dc0b-f49a-1260-3e152a69bef8@enterprisedb.com> (raw)
In-Reply-To: <166740281339.1122.15508017124113465236.pgcf@coridan.postgresql.org>
References: <8cd9fb02-bc26-65f1-a809-b1cb360eef73@enterprisedb.com>
<175ef638-32c7-1a84-590c-6df7497baeea@enterprisedb.com>
<166740281339.1122.15508017124113465236.pgcf@coridan.postgresql.org>
On 02.11.22 16:26, Ankit Kumar Pandey wrote:
> The following review has been posted through the commitfest application:
> make installcheck-world: tested, passed
> Implements feature: tested, passed
> Spec compliant: tested, passed
> Documentation: tested, passed
>
> Hi Peter,
> This is a review of the pclose return value check patch:
>
> Contents & Purpose:
> Purpose of this patch is to properly handle return value of pclose (indirectly, return from ClosePipeStream).
>
> Initial Run:
> The patch applies cleanly to HEAD. The regression tests all pass
> successfully against the new patch.
>
> Conclusion:
> At some places pclose return value is handled and this patch adds return value check for remaining values.
> Implementation is in sync with existing handling of pclose.
Committed. Thanks for the review.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: peter.eisentraut@enterprisedb.com, itsankitkp@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: Check return value of pclose() correctly
In-Reply-To: <e185b889-dc0b-f49a-1260-3e152a69bef8@enterprisedb.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox