From: Jesper Pedersen <jesper.pedersen@redhat.com>
To: Ashutosh Sharma <ashu.coek88@gmail.com>
Cc: Jeff Janes <jeff.janes@gmail.com>
Cc: Michael Paquier <michael.paquier@gmail.com>
Cc: Alvaro Herrera <alvherre@2ndquadrant.com>
Cc: PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: pageinspect: Hash index support
Date: Tue, 20 Sep 2016 14:29:38 -0400
Message-ID: <e1bda3f7-dc99-c610-4d48-58815f5b7515@redhat.com> (raw)
In-Reply-To: <CAE9k0Pk4dC9VrzV7Vm6em7JFzRMGfzx2=eYu0Yb_Psga-W47Ww@mail.gmail.com>
References: <e2ac6c58-b93f-9dd9-f4e6-d6d30add7fdf@redhat.com>
<20160830170633.GA508711@alvherre.pgsql>
<CAMkU=1wghadVOxkphJTQUqukgNkE7ETPci0g55Y+fqXO4Q43PQ@mail.gmail.com>
<0f99b6b0-0e54-0f6e-9502-f8cb6f194c17@redhat.com>
<CAB7nPqSLVbe-wXCd77CMx6vHKfRd6thUwv7nzP54Lv9k4Q6hww@mail.gmail.com>
<3493caf5-6d50-8915-7612-bd830972f513@redhat.com>
<CAMkU=1weMVE+Re7NQyAtXT5g6E5Fziw9PVU9UDapb0AG5MH=YQ@mail.gmail.com>
<CAE9k0Pk4dC9VrzV7Vm6em7JFzRMGfzx2=eYu0Yb_Psga-W47Ww@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>
Hi,
On 09/20/2016 01:46 PM, Ashutosh Sharma wrote:
> I am getting a fatal error along with some warnings when trying to
> apply the v3 patch using "git apply" command.
>
> [ashu@localhost postgresql]$ git apply
> 0001-pageinspect-Hash-index-support_v3.patch
> 0001-pageinspect-Hash-index-support_v3.patch:29: trailing whitespace.
> brinfuncs.o ginfuncs.o hashfuncs.o $(WIN32RES)
> 0001-pageinspect-Hash-index-support_v3.patch:36: trailing whitespace.
> DATA = pageinspect--1.6.sql pageinspect--1.5--1.6.sql \
> 0001-pageinspect-Hash-index-support_v3.patch:37: trailing whitespace.
> pageinspect--1.4--1.5.sql pageinspect--1.3--1.4.sql \
> 0001-pageinspect-Hash-index-support_v3.patch:38: trailing whitespace.
> pageinspect--1.2--1.3.sql pageinspect--1.1--1.2.sql \
> 0001-pageinspect-Hash-index-support_v3.patch:39: trailing whitespace.
> pageinspect--1.0--1.1.sql pageinspect--unpackaged--1.0.sql
> fatal: git apply: bad git-diff - expected /dev/null on line 46
>
Which platform are you on ?
The development branch is @
https://github.com/jesperpedersen/postgres/tree/pageinspect_hash> Also, i think the USAGE for hash_metap() is refering to
> hash_metap_bytea(). Please correct it. I have just started reviewing
> the patch, will keep on posting my comments upon further review.
Fixed in v4.
Thanks for the review.
Best regards,
Jesper
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: jesper.pedersen@redhat.com, ashu.coek88@gmail.com, jeff.janes@gmail.com, michael.paquier@gmail.com, alvherre@2ndquadrant.com
Subject: Re: pageinspect: Hash index support
In-Reply-To: <e1bda3f7-dc99-c610-4d48-58815f5b7515@redhat.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox