public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: Peter Smith <[email protected]>
To: Xiaopeng Wang <[email protected]>
Cc: Chao Li <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Add missing period to DETAIL messages
Date: Wed, 15 Apr 2026 20:26:22 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <CAHut+PsaMX=CF6ASFVyg_mmmz0McDACvNHdV4z77WPE63+YC9Q@mail.gmail.com>
References: <CAHut+PszSntkUgN+Qa9matGY6MLEoFGSuVbuKDgnnTdZ7YPRwg@mail.gmail.com>
	<[email protected]>
	<CAHut+PvAaR3h1wyGgO+761Oa_ywjFToX9AmKNnHhQX6e-N=k_w@mail.gmail.com>
	<CAHut+PtBNKnBVcidXbx4c-ifq44KRb+J4dCUh-2-2sccy0w3Pg@mail.gmail.com>
	<CAHut+Pt=M3AFJjSFHAzgvuxtuQJDnB38FPrA9EH3PsSvZkLcdw@mail.gmail.com>
	<[email protected]>
	<CAHut+PsaMX=CF6ASFVyg_mmmz0McDACvNHdV4z77WPE63+YC9Q@mail.gmail.com>

On 15.04.26 09:41, Peter Smith wrote:
> On Wed, Apr 15, 2026 at 3:48 PM Xiaopeng Wang <[email protected]> wrote:
>>
> ...
>>
>> Looks good to me.
>>
>> A small comment is that, the commit message claims only “add missing period to DETAIL messages”, but apparently the patch also changes capitalization in many places, so the commit message should be updated.
>>
> 
> Fair point. Thanks for your review!
> 
> PSA v4 which has an improved commit message.

Most of these look good, but I don't think this is an improvement:

-DETAIL:  syntax error at end of input
+DETAIL:  syntax error at end of input.

The guidelines say that the detail message should be a sentence.  But 
this is not a sentence.  Just adding a period doesn't make it a 
sentence.  IMO, having a period at the end of a thing that is not a 
sentence is worse than not having it be a sentence.  The latter just 
violates our quality standards, the former is confusing for a user who 
sees that particular output.

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Add missing period to DETAIL messages
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox