pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: postgres_fdw hint messages
Date: Fri, 16 Sep 2022 15:54:53 +0200
Message-ID: <e3ffb099-6ed8-32b7-21d0-bc950e74b3da@enterprisedb.com> (raw)
In-Reply-To: <20220913190255.GA2973985@nathanxps13>
References: <CA+TgmoY+BuSZm-Fbxx5zC6SuML=2F9YvaYuzVAJ=XyE65BnchQ@mail.gmail.com>
	<1929340.1661531738@sss.pgh.pa.us>
	<20220901223128.GA932597@nathanxps13>
	<789102.1662073729@sss.pgh.pa.us>
	<20220901233120.GA934376@nathanxps13>
	<20220902212609.GA1216541@nathanxps13>
	<YxKn9El8Km/3IZuI@paquier.xyz>
	<1267654.1662170814@sss.pgh.pa.us>
	<20220903043058.GA1264318@nathanxps13>
	<0fc339d4-3388-3849-4507-ef0fe0c783fa@enterprisedb.com>
	<20220913190255.GA2973985@nathanxps13>

On 13.09.22 21:02, Nathan Bossart wrote:
> On Tue, Sep 13, 2022 at 08:32:43AM +0200, Peter Eisentraut wrote:
>> I notice that for column misspellings, the hint is phrased "Perhaps you
>> meant X." whereas here we have "Did you mean X?".  Let's make that uniform.
> 
> Good point.  I attached a new version of the patch that uses the column
> phrasing.  I wasn't sure whether "reference" was the right word to use in
> this context, but I used it for now for consistency with the column hints.
> I think "specify" or "use" would work as well.

I don't think we need a verb there at all.  I committed it without a verb.






view thread (18+ messages)  latest in thread

Message-ID: <e3ffb099-6ed8-32b7-21d0-bc950e74b3da@enterprisedb.com>
Permalink:  ../e3ffb099-6ed8-32b7-21d0-bc950e74b3da@enterprisedb.com/
Also on:    postgresql.org/message-id/e3ffb099-6ed8-32b7-21d0-bc950e74b3da@enterprisedb.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: peter.eisentraut@enterprisedb.com, nathandbossart@gmail.com, tgl@sss.pgh.pa.us, michael@paquier.xyz, robertmhaas@gmail.com
  Subject: Re: postgres_fdw hint messages
  In-Reply-To: <e3ffb099-6ed8-32b7-21d0-bc950e74b3da@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox