agora inbox for pgsql-hackers@postgresql.org
help / color / mirror / Atom feedFrom: David Geier <geidav.pg@gmail.com>
To: Andres Freund <andres@anarazel.de>
Cc: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: vignesh C <vignesh21@gmail.com>
Cc: Lukas Fittl <lukas@fittl.com>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Ibrar Ahmed <ibrar.ahmad@gmail.com>
Cc: Maciek Sakrejda <m.sakrejda@gmail.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Reduce timing overhead of EXPLAIN ANALYZE using rdtsc?
Date: Tue, 14 Feb 2023 13:48:56 +0100
Message-ID: <eba40e62-c1d0-810b-55c2-c037a2dc578c@gmail.com> (raw)
In-Reply-To: <989acbcf-e950-7911-c2e2-fe7aa7d15108@gmail.com>
References: <CALDaNm080KHmRHo8OPcAEj+vNzXejwHgmddji5hkAdCwNsuqKA@mail.gmail.com>
<b201ac3c-1bff-2414-be8e-fc287f78be1a@gmail.com>
<c0c253a0-4825-f295-1583-50f9bbab7d5f@enterprisedb.com>
<CAFj8pRBTZ+TrWpigGERq_7ANom1prCucO6qg3jxXssaLMAh2BA@mail.gmail.com>
<b929cab3-c07f-6d89-5a5f-35d5e5e9ba8a@gmail.com>
<24aa958f-0463-03d4-ce54-20b277c954c6@gmail.com>
<20230121041439.zraxavau2wqf2ys3@awork3.anarazel.de>
<b1aff6c5-53a8-65af-2d3e-71ff2c96b0da@gmail.com>
<20230123174158.rhmrbmjp6ycak64r@awork3.anarazel.de>
<a9b2649b-36a0-2e69-e1fd-779e5faf4b7d@gmail.com>
<20230207181218.47irz3of34qsww5l@awork3.anarazel.de>
<989acbcf-e950-7911-c2e2-fe7aa7d15108@gmail.com>
Hi!
On 2/14/23 12:11, David Geier wrote:
> Hi,
>
> I think I fixed the compilation errors. It was due to a few variables
> being declared under
>
> #if defined(__x86_64__) && defined(__linux__)
>
> while being used also under non x86 Linux.
>
> I also removed again the code to obtain the TSC frequency under
> hypervisors because the TSC is usually emulated and therefore no
> faster than clock_gettime() anyways. So we now simply fallback to
> clock_gettime() on hypervisors when we cannot obtain the frequency via
> leaf 0x16.
>
> Beyond that I reviewed the first two patches a while ago in [1]. I
> hope we can progress with them to further reduce the size of this
> patch set.
>
> [1]
> https://www.postgresql.org/message-id/3ac157f7-085d-e071-45fc-b87cd306360c%40gmail.com
>
>
It still fails.
I'll get Cirrus-CI working on my own Github fork so I can make sure it
really compiles on all platforms before I submit a new version.
--
David Geier
(ServiceNow)
view thread (172+ messages) latest in thread
Message-ID: <eba40e62-c1d0-810b-55c2-c037a2dc578c@gmail.com>
Permalink: ../eba40e62-c1d0-810b-55c2-c037a2dc578c@gmail.com/
Also on: postgresql.org/message-id/eba40e62-c1d0-810b-55c2-c037a2dc578c@gmail.com
reply
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: geidav.pg@gmail.com, andres@anarazel.de, pavel.stehule@gmail.com, tomas.vondra@enterprisedb.com, vignesh21@gmail.com, lukas@fittl.com, michael@paquier.xyz, ibrar.ahmad@gmail.com, m.sakrejda@gmail.com
Subject: Re: Reduce timing overhead of EXPLAIN ANALYZE using rdtsc?
In-Reply-To: <eba40e62-c1d0-810b-55c2-c037a2dc578c@gmail.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox